Issue 10582003: Issue 1355. Support for call(). Tweaks for element locator and rename refactoring

Issue 10582003: Issue 1355. Support for call(). Tweaks for element locator and rename refactoring (Closed)

Created:
8 years, 6 months ago by scheglov

Modified:
8 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 1355. Support for call(). Tweaks for element locator and rename refactoring R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8826

Patch Set 1 #

Total comments: 2

Patch Set 2 : Check target range #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -0 lines)			Patch
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View		4 chunks	+59 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java	View	1	2 chunks	+21 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/DartElementLocatorTest.java	View	1	3 chunks	+21 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/RefactoringCoreMessages.java	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/RefactoringCoreMessages.properties	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameMethodProcessor.java	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameMethodProcessorTest.java	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 6 months ago (2012-06-18 20:46:18 UTC) #2

LGTM once DartElementLocator is fixed.

https://chromiumcodereview.appspot.com/10582003/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java
(right):

https://chromiumcodereview.appspot.com/10582003/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java:440:
if (foundElement == null) {
This doesn't test to ensure that the node is within the target range.

https://chromiumcodereview.appspot.com/10582003/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/RefactoringCoreMessages.properties
(right):

https://chromiumcodereview.appspot.com/10582003/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/RefactoringCoreMessages.properties:2:
# Copyright (c) 2000, 2011 IBM Corporation and others.
Shouldn't we have added our copyright to this file?

Expand Messages | Collapse Messages