Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1058123003: Update {virtual,override} to follow C++11 style in sandbox. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in sandbox. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/d6ac192621b71ee5ecdac74082e99346871e5024 Cr-Commit-Position: refs/heads/master@{#326616}

Patch Set 1 #

Total comments: 4

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -57 lines) Patch
M sandbox/linux/bpf_dsl/bpf_dsl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/bpf_tester_compatibility_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M sandbox/linux/seccomp-bpf/bpf_tests.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sandbox/win/src/broker_services.h View 1 1 chunk +11 lines, -11 lines 0 comments Download
M sandbox/win/src/sandbox_policy_base.h View 1 2 chunks +34 lines, -38 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ncarter (slow)
jln@ -- please review this boring change
5 years, 8 months ago (2015-04-23 04:04:55 UTC) #2
jln (very slow on Chromium)
Thanks lgtm, but after you run "git cl format" https://chromiumcodereview.appspot.com/1058123003/diff/1/sandbox/win/src/broker_services.h File sandbox/win/src/broker_services.h (right): https://chromiumcodereview.appspot.com/1058123003/diff/1/sandbox/win/src/broker_services.h#newcode51 sandbox/win/src/broker_services.h:51: ...
5 years, 8 months ago (2015-04-23 17:08:55 UTC) #3
ncarter (slow)
https://codereview.chromium.org/1058123003/diff/1/sandbox/win/src/broker_services.h File sandbox/win/src/broker_services.h (right): https://codereview.chromium.org/1058123003/diff/1/sandbox/win/src/broker_services.h#newcode51 sandbox/win/src/broker_services.h:51: const wchar_t* command_line, On 2015/04/23 17:08:55, jln wrote: > ...
5 years, 8 months ago (2015-04-23 18:30:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058123003/20001
5 years, 8 months ago (2015-04-23 18:34:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-23 19:55:09 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 19:57:04 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6ac192621b71ee5ecdac74082e99346871e5024
Cr-Commit-Position: refs/heads/master@{#326616}

Powered by Google App Engine
This is Rietveld 408576698