Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: media/base/pipeline_unittest.cc

Issue 10581050: Ensure media's buffered ranges always have a range that includes currentTime. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/pipeline_unittest.cc
diff --git a/media/base/pipeline_unittest.cc b/media/base/pipeline_unittest.cc
index b2c08eb5394eeb43c311bc2597d1c2d1c9478573..ef78bd4e669bfa7a9f4619b38efe5eea194ac8a6 100644
--- a/media/base/pipeline_unittest.cc
+++ b/media/base/pipeline_unittest.cc
@@ -480,6 +480,9 @@ TEST_F(PipelineTest, GetBufferedTimeRanges) {
EXPECT_EQ(1u, pipeline_->GetBufferedTimeRanges().size());
EXPECT_EQ(base::TimeDelta(), pipeline_->GetBufferedTimeRanges().start(0));
EXPECT_EQ(kDuration / 8, pipeline_->GetBufferedTimeRanges().end(0));
+ pipeline_->AddBufferedTimeRange(base::TimeDelta(), kDuration / 8);
+ EXPECT_EQ(base::TimeDelta(), pipeline_->GetBufferedTimeRanges().start(0));
+ EXPECT_EQ(kDuration / 8, pipeline_->GetBufferedTimeRanges().end(0));
base::TimeDelta kSeekTime = kDuration / 2;
ExpectSeek(kSeekTime);
@@ -496,6 +499,15 @@ TEST_F(PipelineTest, GetBufferedTimeRanges) {
EXPECT_EQ(kDuration / 2, pipeline_->GetBufferedTimeRanges().start(1));
EXPECT_EQ(kDuration / 2 + kDuration / 8,
pipeline_->GetBufferedTimeRanges().end(1));
+
+ pipeline_->AddBufferedTimeRange(kDuration / 4, 3 * kDuration / 8);
+ EXPECT_EQ(base::TimeDelta(), pipeline_->GetBufferedTimeRanges().start(0));
+ EXPECT_EQ(kDuration / 8, pipeline_->GetBufferedTimeRanges().end(0));
+ EXPECT_EQ(kDuration / 4, pipeline_->GetBufferedTimeRanges().start(1));
+ EXPECT_EQ(3* kDuration / 8, pipeline_->GetBufferedTimeRanges().end(1));
+ EXPECT_EQ(kDuration / 2, pipeline_->GetBufferedTimeRanges().start(2));
+ EXPECT_EQ(kDuration / 2 + kDuration / 8,
+ pipeline_->GetBufferedTimeRanges().end(2));
}
TEST_F(PipelineTest, DisableAudioRenderer) {
« no previous file with comments | « media/base/pipeline.cc ('k') | media/base/ranges.h » ('j') | media/filters/ffmpeg_demuxer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698