Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: media/filters/chunk_demuxer_unittest.cc

Issue 10581050: Ensure media's buffered ranges always have a range that includes currentTime. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Alternative implementation, introducing DataSourceHost::AddBufferedTimeRange(). Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/chunk_demuxer_unittest.cc
diff --git a/media/filters/chunk_demuxer_unittest.cc b/media/filters/chunk_demuxer_unittest.cc
index 9f14b790cc65904290ab663a10173818d6f2f768..83234070432e2566ec4fb798a98db5ca2e81efa0 100644
--- a/media/filters/chunk_demuxer_unittest.cc
+++ b/media/filters/chunk_demuxer_unittest.cc
@@ -126,8 +126,7 @@ class ChunkDemuxerTest : public testing::Test {
}
ChunkDemuxerTest()
- : buffered_bytes_(0),
- client_(new MockChunkDemuxerClient()),
+ : client_(new MockChunkDemuxerClient()),
demuxer_(new ChunkDemuxer(client_.get())) {
}
@@ -237,8 +236,8 @@ class ChunkDemuxerTest : public testing::Test {
bool AppendData(const std::string& source_id,
const uint8* data, size_t length) {
CHECK(length);
- EXPECT_CALL(host_, AddBufferedByteRange(_, _)).Times(AnyNumber())
- .WillRepeatedly(SaveArg<1>(&buffered_bytes_));
+ EXPECT_CALL(host_, AddBufferedTimeRange(_, _)).Times(AnyNumber())
+ .WillRepeatedly(SaveArg<1>(&buffered_time_));
return demuxer_->AppendData(source_id, data, length);
}
@@ -250,14 +249,14 @@ class ChunkDemuxerTest : public testing::Test {
const uint8* start = data;
const uint8* end = data + length;
while (start < end) {
- int64 old_buffered_bytes = buffered_bytes_;
+ base::TimeDelta old_buffered_time = buffered_time_;
size_t append_size = std::min(piece_size,
static_cast<size_t>(end - start));
if (!AppendData(start, append_size))
return false;
start += append_size;
- EXPECT_GE(buffered_bytes_, old_buffered_bytes);
+ EXPECT_GE(buffered_time_, old_buffered_time);
}
return true;
}
@@ -570,7 +569,7 @@ class ChunkDemuxerTest : public testing::Test {
}
MockDemuxerHost host_;
- int64 buffered_bytes_;
+ base::TimeDelta buffered_time_;
scoped_ptr<MockChunkDemuxerClient> client_;
scoped_refptr<ChunkDemuxer> demuxer_;

Powered by Google App Engine
This is Rietveld 408576698