Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 10581049: - Implement the filtering store barrier on x64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/assembler_x64.h ('K') | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/stub_code_x64.cc » ('j') | runtime/vm/stub_code_x64.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_ia32.cc
===================================================================
--- runtime/vm/stub_code_ia32.cc (revision 8929)
+++ runtime/vm/stub_code_ia32.cc (working copy)
@@ -1084,7 +1084,6 @@
// Input parameters:
// EAX: Address being stored
void StubCode::GenerateUpdateStoreBufferStub(Assembler* assembler) {
- Label L;
// Save values being destroyed.
__ pushl(CTX);
__ pushl(EBX);
@@ -1107,6 +1106,7 @@
// Increment top_ and check for overflow.
// EBX: top_
// CTX: Isolate
+ Label L;
__ incl(EBX);
__ movl(Address(CTX, store_buffer_offset + StoreBufferBlock::top_offset()),
EBX);
@@ -1119,7 +1119,6 @@
Immediate(0));
__ Bind(&L);
-
// Restore values.
__ popl(EBX);
__ popl(CTX);
« runtime/vm/assembler_x64.h ('K') | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/stub_code_x64.cc » ('j') | runtime/vm/stub_code_x64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698