- Implement the filtering store barrier on x64.

runtime/vm/stub_code_ia32.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/assembler.h"
 #include "vm/assembler_macros.h"
 #include "vm/code_generator.h"
@@ skipping 1066 matching lines @@
   // Restore the frame pointer.
   __ LeaveFrame();
   __ ret();
 }
 
 
 // Helper stub to implement Assembler::StoreIntoObject.
 // Input parameters:
 //   EAX: Address being stored
 void StubCode::GenerateUpdateStoreBufferStub(Assembler* assembler) {
-  Label L;
   // Save values being destroyed.
   __ pushl(CTX);
   __ pushl(EBX);
 
   // Load the isolate out of the context.
   // EAX: Address being stored
   __ movl(CTX, FieldAddress(CTX, Context::isolate_offset()));
 
   // Load top_ out of the StoreBufferBlock and add the address to the pointers_.
   // EAX: Address being stored
   // CTX: Isolate
   intptr_t store_buffer_offset = Isolate::store_buffer_offset();
   __ movl(EBX,
           Address(CTX, store_buffer_offset + StoreBufferBlock::top_offset()));
   __ movl(Address(CTX,
                   EBX, TIMES_4,
                   store_buffer_offset + StoreBufferBlock::pointers_offset()),
           EAX);
 
   // Increment top_ and check for overflow.
   // EBX: top_
   // CTX: Isolate
+  Label L;
   __ incl(EBX);
   __ movl(Address(CTX, store_buffer_offset + StoreBufferBlock::top_offset()),
           EBX);
   __ cmpl(EBX, Immediate(StoreBufferBlock::kSize));
   __ j(NOT_EQUAL, &L, Assembler::kNearJump);
 
   // Handle overflow: Reset the top_ pointer.
   // CTX: Isolate
   __ movl(Address(CTX, store_buffer_offset + StoreBufferBlock::top_offset()),
           Immediate(0));
 
   __ Bind(&L);
-
   // Restore values.
   __ popl(EBX);
   __ popl(CTX);
   __ ret();
 }
 
 
 // Called for inline allocation of objects.
 // Input parameters:
 //   ESP + 8 : type arguments object (only if class is parameterized).
@@ skipping 770 matching lines @@
 // TOS + 2: instance.
 // TOS + 3: cache array.
 // Result in ECX: null -> not found, otherwise result (true or false).
 void StubCode::GenerateSubtype3TestCacheStub(Assembler* assembler) {
   GenerateSubtypeNTestCacheStub(assembler, 3);
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32