chrome/installer/util/shell_util.cc - Issue 10581040: Merge 142911 - Notify Windows Shell after making Chrome default interactively

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/shell_util.cc

Issue 10581040: Merge 142911 - Notify Windows Shell after making Chrome default interactively (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1180/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/shell_util.cc

===================================================================

--- chrome/installer/util/shell_util.cc (revision 143182)

+++ chrome/installer/util/shell_util.cc (working copy)

@@ -610,7 +610,10 @@

HRESULT hr = SHOpenWithDialog(NULL, &open_as_info);

DLOG_IF(WARNING, FAILED(hr)) << "Failed to set as default " << protocol

<< " handler; hr=0x" << std::hex << hr;

- return SUCCEEDED(hr);

+ if (FAILED(hr))

+ return false;

+ SHChangeNotify(SHCNE_ASSOCCHANGED, SHCNF_IDLIST, NULL, NULL);

+ return true;

}

// Launches the Windows 7 and Windows 8 application association dialog, which

« no previous file with comments | « no previous file | no next file » | no next file with comments »