Issue 10581036: Ensure uniqueness of global names.

Issue 10581036: Ensure uniqueness of global names. (Closed)

Created:
8 years, 6 months ago by ahe

Modified:
8 years, 6 months ago

Reviewers:
floitsch, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Ensure uniqueness of global names. Committed: https://code.google.com/p/dart/source/detail?r=8896

Patch Set 2 : Restore caching the count #

Total comments: 4

Patch Set 3 : Update comment #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -13 lines)			Patch
M	dart/.gitignore	View		1 chunk	+10 lines, -2 lines	0 comments	Download
A	dart/language/namer_test.dart	View	1	1 chunk	+63 lines, -0 lines	0 comments	Download
M	dart/lib/compiler/implementation/namer.dart	View	1 2	1 chunk	+10 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/10581036/diff/3001/dart/lib/compiler/implementation/namer.dart File dart/lib/compiler/implementation/namer.dart (right): https://chromiumcodereview.appspot.com/10581036/diff/3001/dart/lib/compiler/implementation/namer.dart#newcode117 dart/lib/compiler/implementation/namer.dart:117: // frequently see the name again, as all ...

8 years, 6 months ago (2012-06-20 11:04:06 UTC) #5

ahe

8 years, 6 months ago (2012-06-20 11:15:59 UTC) #6

Thank you, Florian and Kasper!

https://chromiumcodereview.appspot.com/10581036/diff/3001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/namer.dart (right):

https://chromiumcodereview.appspot.com/10581036/diff/3001/dart/lib/compiler/i...
dart/lib/compiler/implementation/namer.dart:117: // frequently see the name
again, as all our closures use the
On 2012/06/20 11:04:06, floitsch wrote:
> frequently see names multiple times

Done.

https://chromiumcodereview.appspot.com/10581036/diff/3001/dart/lib/compiler/i...
dart/lib/compiler/implementation/namer.dart:121: usedGlobals[name] = 0;
On 2012/06/20 11:04:06, floitsch wrote:
> usedGlobals.putIfAbsent(name, () => 0) ?

At this point we know that usedGlobals[name] === null.

Expand Messages | Collapse Messages