Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 10581025: Add quotes around command line arg to allow a wider range of URLs. (Closed)

Created:
8 years, 6 months ago by Satish
Modified:
8 years, 6 months ago
Reviewers:
John Grabowski, Yaron
CC:
chromium-reviews
Visibility:
Public.

Description

Add quotes around command line arg to allow a wider range of URLs. Without quotes the shell complains when trying to open URLs with shell special characters including parentheses, single/double quotes etc. (e.g. data URLs) TEST=adb_run_content_shell "data:text/html,<script>console.log(1);</script>" BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143080

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/adb_run_content_shell View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Satish
8 years, 6 months ago (2012-06-19 21:38:51 UTC) #1
Yaron
On 2012/06/19 21:38:51, Satish wrote: lgtm
8 years, 6 months ago (2012-06-19 21:55:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satish@chromium.org/10581025/1
8 years, 6 months ago (2012-06-19 22:07:01 UTC) #3
John Grabowski
You go girl! LGTM
8 years, 6 months ago (2012-06-19 22:45:39 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-19 23:17:09 UTC) #5
Change committed as 143080

Powered by Google App Engine
This is Rietveld 408576698