Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 10581020: Prevent requests for http://host:port/ from being sent over an existing spdy session to https://hos… (Closed)

Created:
8 years, 6 months ago by Ryan Hamilton
Modified:
8 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Prevent requests for http://host:port/ from being sent over an existing spdy session to https://host:port/. BUG=133176 TEST=HttpNetworkTransactionSpdy\*Test.\*UseSpdySessionForHttp\* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145172

Patch Set 1 #

Patch Set 2 : Fix willchan's comments #

Total comments: 4

Patch Set 3 : Rebase, I think #

Patch Set 4 : Actually rebase correctly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+523 lines, -6 lines) Patch
M net/http/http_network_transaction_spdy2_unittest.cc View 1 2 3 1 chunk +254 lines, -0 lines 0 comments Download
M net/http/http_network_transaction_spdy3_unittest.cc View 1 2 3 1 chunk +244 lines, -0 lines 0 comments Download
M net/http/http_stream_factory_impl_job.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 2 3 4 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ryan Hamilton
Hi Will, Can you take a look? After moving my tests to HttpNetworkTransaction they work ...
8 years, 6 months ago (2012-06-19 19:21:27 UTC) #1
Ryan Hamilton
Hi will, I added test of the http request though SPDY proxy after connect tunnel ...
8 years, 6 months ago (2012-06-19 23:53:45 UTC) #2
Ryan Hamilton
On 2012/06/19 23:53:45, Ryan Hamilton wrote: > Hi will, > > I added test of ...
8 years, 6 months ago (2012-06-22 23:12:15 UTC) #3
willchan no longer on Chromium
http://codereview.chromium.org/10581020/diff/3001/net/http/http_network_transaction_spdy3_unittest.cc File net/http/http_network_transaction_spdy3_unittest.cc (right): http://codereview.chromium.org/10581020/diff/3001/net/http/http_network_transaction_spdy3_unittest.cc#newcode9742 net/http/http_network_transaction_spdy3_unittest.cc:9742: const std::string httpsUrl = "https://www.google.com/"; https_url http://codereview.chromium.org/10581020/diff/3001/net/http/http_stream_factory_impl_job.cc File net/http/http_stream_factory_impl_job.cc ...
8 years, 5 months ago (2012-06-29 17:19:45 UTC) #4
Ryan Hamilton
Raman, I've fixed will's comments but he would like you to take a look at ...
8 years, 5 months ago (2012-06-29 17:37:34 UTC) #5
ramant (doing other things)
lgtm
8 years, 5 months ago (2012-07-02 16:47:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/10581020/10001
8 years, 5 months ago (2012-07-02 16:55:14 UTC) #7
commit-bot: I haz the power
Failed to apply patch for net/http/http_network_transaction_spdy2_unittest.cc: While running patch -p1 --forward --force; patching file net/http/http_network_transaction_spdy2_unittest.cc ...
8 years, 5 months ago (2012-07-02 16:55:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/10581020/18001
8 years, 5 months ago (2012-07-02 17:52:14 UTC) #9
commit-bot: I haz the power
8 years, 5 months ago (2012-07-02 19:14:06 UTC) #10
Change committed as 145172

Powered by Google App Engine
This is Rietveld 408576698