Make the default startup pref to be NTP also on Mac.

Make the default startup pref to be NTP also on Mac.

BUG=133473
TEST=Manual.

[marja, 2012-06-19 09:21:29]

battre, ptal.

[marja, 2012-06-19 09:49:23]

.. fixed

[battre, 2012-06-19 10:42:58]

lgtm

[commit-bot: I haz the power, 2012-06-19 10:47:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/10581013/3001

[commit-bot: I haz the power, 2012-06-19 14:15:18]

Try job failure for 10581013-3001 (retry) on win_rel for step
"chrome_frame_net_tests".
It's a second try, previously, step "chrome_frame_net_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-06-19 14:16:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/10581013/3001

[Joao da Silva, 2012-06-19 15:23:00]

I don't agree with this change :-) But please consider the inline comment if you
go ahead with it anyway.

https://chromiumcodereview.appspot.com/10581013/diff/3001/chrome/browser/pref...
File chrome/browser/prefs/session_startup_pref.cc (right):

https://chromiumcodereview.appspot.com/10581013/diff/3001/chrome/browser/pref...
chrome/browser/prefs/session_startup_pref.cc:198:
prefs->SetInteger(prefs::kRestoreOnStartup, kPrefValueLast);
kPrevValueLast might not be the right value here, depending on the Lion system
setting. If restore_utils::IsWindowRestoreEnabled() is false, then this should
be kPrefValueNewTab.

[marja, 2012-06-19 15:24:48]

https://chromiumcodereview.appspot.com/10581013/diff/3001/chrome/browser/pref...
File chrome/browser/prefs/session_startup_pref.cc (right):

https://chromiumcodereview.appspot.com/10581013/diff/3001/chrome/browser/pref...
chrome/browser/prefs/session_startup_pref.cc:198:
prefs->SetInteger(prefs::kRestoreOnStartup, kPrefValueLast);
On 2012/06/19 15:23:00, Joao da Silva wrote:
> kPrevValueLast might not be the right value here, depending on the Lion system
> setting. If restore_utils::IsWindowRestoreEnabled() is false, then this should
> be kPrefValueNewTab.

This code only gets executed if restore_utils::IsWindowRestoreEnabled() is true
(see above).

[Joao da Silva, 2012-06-19 15:24:50]

On 2012/06/19 15:23:00, Joao da Silva wrote:
> I don't agree with this change :-) But please consider the inline comment if
you
> go ahead with it anyway.

Actually, I just realized the code is correct, please ignore.

> 
>
https://chromiumcodereview.appspot.com/10581013/diff/3001/chrome/browser/pref...
> File chrome/browser/prefs/session_startup_pref.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10581013/diff/3001/chrome/browser/pref...
> chrome/browser/prefs/session_startup_pref.cc:198:
> prefs->SetInteger(prefs::kRestoreOnStartup, kPrefValueLast);
> kPrevValueLast might not be the right value here, depending on the Lion system
> setting. If restore_utils::IsWindowRestoreEnabled() is false, then this should
> be kPrefValueNewTab.

[marja, 2012-06-22 19:17:12]

Hmm, for some reason this didn't get closed automatically when committed
(revision 142958). Closing manually...