Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 10581012: Move test_url_fetcher_factory.* from content/ to net/url_request (Closed)

Created:
8 years, 6 months ago by akalin
Modified:
8 years, 6 months ago
Reviewers:
wtc
CC:
chromium-reviews, Ilya Sherman, mihaip-chromium-reviews_chromium.org, dyu1, jochen+watch-content_chromium.org, ncarter (slow), dhollowa+watch_chromium.org, akalin, cbentzel+watch_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, Satish, darin-cc_chromium.org, tim (not reviewing), oshima+watch_chromium.org, Raghu Simha, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Move test_url_fetcher_factory.* from content/ to net/url_request Also mark URLFetcherImpl as NET_EXPORT_PRIVATE instead of NET_EXPORT, as it shouldn't be used except for some code in test_url_fetcher_factory.*. Update all references. BUG=118220 TEST= TBR=jam@chromium.org,jhawkins@chromium.org,mnissler@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143085

Patch Set 1 #

Patch Set 2 : Sync to head, fix chromeos #

Patch Set 3 : fix another chromeos compile failure #

Patch Set 4 : Fix win compile #

Patch Set 5 : Remove export annotations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -920 lines) Patch
M chrome/browser/autocomplete/search_provider_unittest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/autofill/autofill_download_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_service_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 2 8 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/mock_url_fetchers.h View 1 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/mock_url_fetchers.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/app_notify_channel_setup_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 18 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/google/google_url_tracker_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/intents/cws_intents_registry_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/policy/device_management_service_unittest.cc View 17 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/policy/testing_policy_url_fetcher_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/testing_policy_url_fetcher_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 12 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/signin/signin_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/signin/token_service_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/signin/ubertoken_fetcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spelling_service_client_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/http_bridge_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher_unittest.cc View 12 chunks +14 lines, -14 lines 0 comments Download
M chrome/common/net/gaia/gaia_oauth_client_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/net/gaia/mock_url_fetcher_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/net/gaia/oauth2_access_token_fetcher_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/net/gaia/oauth2_api_call_flow_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/net/gaia/oauth2_mint_token_fetcher_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/net/gaia/oauth2_mint_token_flow_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/net/gaia/oauth2_revocation_fetcher_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/geolocation/network_location_provider_unittest.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M content/browser/speech/google_one_shot_remote_engine_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/speech/speech_recognizer_impl_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
D content/public/test/test_url_fetcher_factory.h View 1 chunk +0 lines, -296 lines 0 comments Download
D content/test/test_url_fetcher_factory.cc View 1 chunk +0 lines, -342 lines 0 comments Download
M net/net.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + net/url_request/test_url_fetcher_factory.h View 1 2 3 4 13 chunks +41 lines, -38 lines 0 comments Download
A + net/url_request/test_url_fetcher_factory.cc View 12 chunks +35 lines, -31 lines 0 comments Download
M net/url_request/url_fetcher_impl.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
akalin
+wtc for review I'll TBR all the OWNERS
8 years, 6 months ago (2012-06-19 09:18:31 UTC) #1
wtc
Patch set 3 LGTM.
8 years, 6 months ago (2012-06-19 18:52:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/10581012/11001
8 years, 6 months ago (2012-06-19 18:59:05 UTC) #3
commit-bot: I haz the power
Presubmit check for 10581012-11001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-19 18:59:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/10581012/11001
8 years, 6 months ago (2012-06-19 19:20:39 UTC) #5
commit-bot: I haz the power
Try job failure for 10581012-11001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-06-19 20:01:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/10581012/6003
8 years, 6 months ago (2012-06-19 20:45:58 UTC) #7
commit-bot: I haz the power
Try job failure for 10581012-6003 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-06-19 21:57:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/10581012/3006
8 years, 6 months ago (2012-06-19 22:34:38 UTC) #9
commit-bot: I haz the power
8 years, 6 months ago (2012-06-19 23:44:17 UTC) #10
Change committed as 143085

Powered by Google App Engine
This is Rietveld 408576698