Correct the masks and conditions used to filter cross generation stores.

runtime/vm/assembler_ia32.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/assembler.h"
 #include "vm/heap.h"
 #include "vm/memory_region.h"
@@ skipping 1376 matching lines @@
 
 
 void Assembler::StoreIntoObject(Register object,
                                 const FieldAddress& dest,
                                 Register value) {
   movl(dest, value);
   Label done;
   // Check that 'value' is a new object.  Store buffer updates are not
   // required when storing a smi or an old object.
   testl(value, Immediate(kNewObjectAlignmentOffset | kHeapObjectTag));
-  j(NOT_EQUAL, &done, Assembler::kNearJump);
+  j(PARITY_ODD, &done, Assembler::kNearJump);
   // Check that 'object' is an old object.  A store buffer update is
   // not required when storing into a new object.
-  testl(object, Immediate(kOldObjectAlignmentOffset | kHeapObjectTag));
-  j(NOT_EQUAL, &done, Assembler::kNearJump);
+  testl(object, Immediate(kNewObjectAlignmentOffset));
+  j(NOT_ZERO, &done, Assembler::kNearJump);
   // A store buffer update is required.
   pushal();
   pushl(dest);  // Push argument
   CallRuntime(kStoreBufferRuntimeEntry);
   popl(value);  // Pop argument
   popal();
   Bind(&done);
 }
 
 
 void Assembler::StoreIntoObjectNoBarrier(Register object,
                                          const FieldAddress& dest,
                                          Register value) {
   movl(dest, value);
 #if defined(DEBUG)
   Label done;
   testl(value, Immediate(kNewObjectAlignmentOffset | kHeapObjectTag));
-  j(NOT_EQUAL, &done, Assembler::kNearJump);
-  testl(object, Immediate(kOldObjectAlignmentOffset | kHeapObjectTag));
-  j(NOT_EQUAL, &done, Assembler::kNearJump);
+  j(PARITY_ODD, &done, Assembler::kNearJump);
+  testl(object, Immediate(kNewObjectAlignmentOffset));
+  j(NOT_ZERO, &done, Assembler::kNearJump);
   Stop("Store buffer update is required");
   Bind(&done);
 #endif
   // No store buffer update.
 }
 
 
 void Assembler::StoreIntoObjectNoBarrier(Register object,
                                          const FieldAddress& dest,
                                          const Object& value) {
@@ skipping 286 matching lines @@
     comments.SetCommentAt(i, comments_[i]->comment());
   }
 
   return comments;
 }
 
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32