Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 10580039: Adds ability to render omnibox as a view above the page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix windows Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
index c0acec398f6a70ae09986d935a4197ed5d7108ab..4d2c6d9a5ccb1999ed1117966a23c22e7df305b0 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
@@ -211,7 +211,7 @@ OmniboxViewViews::~OmniboxViewViews() {
////////////////////////////////////////////////////////////////////////////////
// OmniboxViewViews public:
-void OmniboxViewViews::Init() {
+void OmniboxViewViews::Init(views::View* popup_parent_view) {
// The height of the text view is going to change based on the font used. We
// don't want to stretch the height, and we want it vertically centered.
// TODO(oshima): make sure the above happens with views.
@@ -229,8 +229,9 @@ void OmniboxViewViews::Init() {
// Create popup view using the same font as |textfield_|'s.
popup_view_.reset(
- OmniboxPopupContentsView::CreateForEnvironment(
- textfield_->font(), this, model_.get(), location_bar_view_));
+ OmniboxPopupContentsView::Create(
+ textfield_->font(), this, model_.get(), location_bar_view_,
+ popup_parent_view));
const int vertical_margin = !popup_window_mode_ ?
kAutocompleteVerticalMargin : kAutocompleteVerticalMarginInPopup;

Powered by Google App Engine
This is Rietveld 408576698