Issue 10579050: Linux: Return a failure in ReadProcStats() if the stat file is empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10579050: Linux: Return a failure in ReadProcStats() if the stat file is empty. (Closed)

Created:
8 years, 6 months ago by Lei Zhang

Modified:
8 years, 6 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org, grt (UTC plus 2)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Linux: Return a failure in ReadProcStats() if the stat file is empty. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143326

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	base/process_util_linux.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

grt@ saw a case where ReadProcStats() returned true, but read an empty file. Then ParseProcStats() ...

8 years, 6 months ago (2012-06-20 20:05:46 UTC) #1

willchan no longer on Chromium

lgtm On Wed, Jun 20, 2012 at 1:07 PM, <grt@chromium.org> wrote: > lgtm. thanks for ...

8 years, 6 months ago (2012-06-20 23:31:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10579050/1

8 years, 6 months ago (2012-06-20 23:39:45 UTC) #4

commit-bot: I haz the power

8 years, 6 months ago (2012-06-21 00:40:40 UTC) #5

Try job failure for 10579050-1 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Expand Messages | Collapse Messages