Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 10579040: APK-based unittests (Closed)

Created:
8 years, 6 months ago by bulach
Modified:
8 years, 5 months ago
Reviewers:
John Grabowski, nilesh
CC:
chromium-reviews
Visibility:
Public.

Description

APK-based unittests Rather than chromium's LOG(ERROR) uses directly __android_log_write for the gtest printer. Cleans up the log and make it simpler to spot real errors. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144428

Patch Set 1 #

Patch Set 2 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M testing/android/native_test_launcher.cc View 1 4 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bulach
8 years, 6 months ago (2012-06-20 11:26:43 UTC) #1
nilesh
On 2012/06/20 11:26:43, bulach wrote: LGTM
8 years, 6 months ago (2012-06-20 15:32:02 UTC) #2
bulach
On 2012/06/20 15:32:02, nileshagrawal1 wrote: > On 2012/06/20 11:26:43, bulach wrote: > > LGTM thanks! ...
8 years, 6 months ago (2012-06-20 15:33:28 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 6 months ago (2012-06-20 15:33:42 UTC) #4
bulach
8 years, 6 months ago (2012-06-20 15:34:44 UTC) #5
John Grabowski
Consider adding a new macro in here to make the code simpler
8 years, 6 months ago (2012-06-20 17:44:09 UTC) #6
bulach
thanks john! re-upstreaming this, another look please?
8 years, 5 months ago (2012-06-26 10:05:13 UTC) #7
John Grabowski
LGTM
8 years, 5 months ago (2012-06-26 18:05:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/10579040/7001
8 years, 5 months ago (2012-06-27 08:09:02 UTC) #9
commit-bot: I haz the power
8 years, 5 months ago (2012-06-27 09:48:09 UTC) #10
Change committed as 144428

Powered by Google App Engine
This is Rietveld 408576698