Issue 10579034: Removing incorrect usage of TO_L_STRING() macros.

Issue 10579034: Removing incorrect usage of TO_L_STRING() macros. (Closed)

Created:
8 years, 6 months ago by alexeypa (please no reviews)

Modified:
8 years, 6 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Removing incorrect usage of TO_L_STRING() macros. BUG=133003 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143194

Patch Set 1 #

Patch Set 2 : rebased #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -58 lines)			Patch
M	remoting/host/branding.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/branding.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	remoting/host/capturer_win.cc	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	remoting/host/elevated_controller_win.cc	View		3 chunks	+5 lines, -6 lines	0 comments	Download
M	remoting/host/host_service_win.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	remoting/host/host_service_win.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	remoting/host/plugin/daemon_controller_win.cc	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	remoting/host/plugin/daemon_installer_win.cc	View		4 chunks	+14 lines, -13 lines	0 comments	Download
M	remoting/host/sas_injector_win.cc	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	remoting/host/wts_session_process_launcher_win.cc	View		8 chunks	+12 lines, -14 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10579034/1

8 years, 6 months ago (2012-06-20 00:38:25 UTC) #3

commit-bot: I haz the power

Failed to apply patch for remoting/host/capturer_win.cc: While running patch -p1 --forward --force; patching file remoting/host/capturer_win.cc ...

8 years, 6 months ago (2012-06-20 00:38:34 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10579034/5001

8 years, 6 months ago (2012-06-20 15:43:46 UTC) #5

commit-bot: I haz the power

8 years, 6 months ago (2012-06-20 15:43:50 UTC) #6

Presubmit check for 10579034-5001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
New code should not use wstrings.  If you are calling an API that accepts a
wstring, fix the API.
    remoting/host/host_service_win.h:91
    remoting/host/plugin/daemon_installer_win.cc:284
    remoting/host/plugin/daemon_installer_win.cc:293
    remoting/host/wts_session_process_launcher_win.cc:150
    remoting/host/wts_session_process_launcher_win.cc:159
    remoting/host/wts_session_process_launcher_win.cc:179
    remoting/host/wts_session_process_launcher_win.cc:182
    remoting/host/wts_session_process_launcher_win.cc:212
    remoting/host/wts_session_process_launcher_win.cc:215
    remoting/host/wts_session_process_launcher_win.cc:282

Expand Messages | Collapse Messages