Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: lib/compiler/implementation/compiler.dart

Issue 10579019: First shot at source maps generation in dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Return source map via diagnostic handler. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/compiler.dart
diff --git a/lib/compiler/implementation/compiler.dart b/lib/compiler/implementation/compiler.dart
index 110d9d70608650a030bc9aa81822086d5f6a87b8..c3892ec7619b8824edc92552e8bc1e9433e8e96a 100644
--- a/lib/compiler/implementation/compiler.dart
+++ b/lib/compiler/implementation/compiler.dart
@@ -61,8 +61,8 @@ class JavaScriptBackend extends Backend {
return <CompilerTask>[builder, optimizer, generator, emitter];
}
- JavaScriptBackend(Compiler compiler)
- : emitter = new CodeEmitterTask(compiler),
+ JavaScriptBackend(Compiler compiler, [bool generateSourceMap = false])
ahe 2012/06/20 11:56:59 Prefer no optional arguments to a method (or const
podivilov 2012/06/20 14:15:15 Done.
+ : emitter = new CodeEmitterTask(compiler, generateSourceMap),
super(compiler) {
builder = new SsaBuilderTask(this);
optimizer = new SsaOptimizerTask(this);
@@ -192,7 +192,8 @@ class Compiler implements DiagnosticListener {
this.enableTypeAssertions = false,
this.enableUserAssertions = false,
bool emitJavascript = true,
- validateUnparse = false])
+ validateUnparse = false,
+ generateSourceMap = false])
ahe 2012/06/20 11:56:59 I think the default should be true.
podivilov 2012/06/20 14:15:15 Done.
: libraries = new Map<String, LibraryElement>(),
world = new World(),
progress = new Stopwatch.start() {
@@ -206,7 +207,8 @@ class Compiler implements DiagnosticListener {
resolver = new ResolverTask(this);
checker = new TypeCheckerTask(this);
backend = emitJavascript ?
- new JavaScriptBackend(this) : new dart_backend.DartBackend(this);
+ new JavaScriptBackend(this, generateSourceMap) :
+ new dart_backend.DartBackend(this);
enqueuer = new EnqueueTask(this);
tasks = [scanner, dietParser, parser, resolver, checker,
unparseValidator, constantHandler, enqueuer];

Powered by Google App Engine
This is Rietveld 408576698