Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: build/android/cmd_helper.py

Issue 10578032: Upstreaming android build tools (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/adb_logcat_printer.py ('k') | build/android/device_status_check.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/cmd_helper.py
diff --git a/build/android/cmd_helper.py b/build/android/cmd_helper.py
index 901cbe9aed76e110da5f2c06bc652fcda522fb00..ccf457ebaf2fc39869aa96fcd4ef8d92cf692f51 100644
--- a/build/android/cmd_helper.py
+++ b/build/android/cmd_helper.py
@@ -21,7 +21,7 @@ def RunCmd(args, cwd=None):
return p.wait()
-def GetCmdOutput(args, cwd=None):
+def GetCmdOutput(args, cwd=None, shell=False):
"""Open a subprocess to execute a program and returns its output.
Args:
@@ -32,7 +32,7 @@ def GetCmdOutput(args, cwd=None):
"""
logging.info(str(args) + ' ' + (cwd or ''))
p = subprocess.Popen(args=args, cwd=cwd, stdout=subprocess.PIPE,
- stderr=subprocess.PIPE)
+ stderr=subprocess.PIPE, shell=shell)
stdout, stderr = p.communicate()
if stderr:
logging.critical(stderr)
« no previous file with comments | « build/android/adb_logcat_printer.py ('k') | build/android/device_status_check.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698