Issue 10578032: Upstreaming android build tools

Issue 10578032: Upstreaming android build tools (Closed)

Created:
8 years, 6 months ago by Isaac (away)

Modified:
8 years, 6 months ago

Reviewers:
bulach, Yaron

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Upstreaming android build tools - These are used to monitor and debug devices when running tests Hooks will be added in a separate CL. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143261

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Fixed lint issues #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+491 lines, -2 lines)			Patch
A	build/android/adb_logcat_monitor.py	View		1 chunk	+155 lines, -0 lines	0 comments	Download
A	build/android/adb_logcat_printer.py	View		1 chunk	+202 lines, -0 lines	0 comments	Download
M	build/android/cmd_helper.py	View	1 2	3 chunks	+14 lines, -2 lines	0 comments	Download
A	build/android/device_status_check.py	View		1 chunk	+120 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Isaac (away)

Only change from downstream is a URL in device_health_status which I had to change

8 years, 6 months ago (2012-06-20 05:00:59 UTC) #2

Yaron

Please run gpylint on all these files. https://chromiumcodereview.appspot.com/10578032/diff/3001/build/android/cmd_helper.py File build/android/cmd_helper.py (right): https://chromiumcodereview.appspot.com/10578032/diff/3001/build/android/cmd_helper.py#newcode30 build/android/cmd_helper.py:30: cwd: If ...

8 years, 6 months ago (2012-06-20 17:31:03 UTC) #3

Isaac (away)

Done. cmd_helper was the only file with warnings and I've fixed them.

8 years, 6 months ago (2012-06-20 19:57:25 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/10578032/8001

8 years, 6 months ago (2012-06-20 20:11:09 UTC) #6

Change committed as 143261

Expand Messages | Collapse Messages