Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: chrome/browser/search_engines/template_url_service.cc

Issue 10578017: Test GURL::spec() usage changes with DEPS rolled to the new version. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More fixes Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_service.cc
diff --git a/chrome/browser/search_engines/template_url_service.cc b/chrome/browser/search_engines/template_url_service.cc
index 7f7b6623f4b60e004e60f91afc904bd5df31e392..39a6f17811c4f44f852a950ce83a09eb01240c90 100644
--- a/chrome/browser/search_engines/template_url_service.cc
+++ b/chrome/browser/search_engines/template_url_service.cc
@@ -317,9 +317,10 @@ GURL TemplateURLService::GenerateSearchURLUsingTermsData(
if (!search_ref.SupportsReplacementUsingTermsData(search_terms_data))
return GURL(t_url->url());
- return GURL(search_ref.ReplaceSearchTermsUsingTermsData(
+ GURL search_url(search_ref.ReplaceSearchTermsUsingTermsData(
ASCIIToUTF16(kReplacementTerm), TemplateURLRef::NO_SUGGESTIONS_AVAILABLE,
string16(), search_terms_data));
+ return search_url.is_valid() ? search_url : GURL();
}
bool TemplateURLService::CanReplaceKeyword(

Powered by Google App Engine
This is Rietveld 408576698