Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: sync/internal_api/write_node.cc

Issue 10578017: Test GURL::spec() usage changes with DEPS rolled to the new version. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More fixes Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/url_request/view_cache_helper.cc ('k') | webkit/database/database_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/internal_api/public/write_node.h" 5 #include "sync/internal_api/public/write_node.h"
6 6
7 #include "base/utf_string_conversions.h" 7 #include "base/utf_string_conversions.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "sync/engine/nigori_util.h" 9 #include "sync/engine/nigori_util.h"
10 #include "sync/internal_api/public/base_transaction.h" 10 #include "sync/internal_api/public/base_transaction.h"
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 entry_->Put(syncable::NON_UNIQUE_NAME, new_legal_title); 100 entry_->Put(syncable::NON_UNIQUE_NAME, new_legal_title);
101 101
102 DVLOG(1) << "Overwriting title of type " 102 DVLOG(1) << "Overwriting title of type "
103 << syncable::ModelTypeToString(type) 103 << syncable::ModelTypeToString(type)
104 << " and marking for syncing."; 104 << " and marking for syncing.";
105 MarkForSyncing(); 105 MarkForSyncing();
106 } 106 }
107 107
108 void WriteNode::SetURL(const GURL& url) { 108 void WriteNode::SetURL(const GURL& url) {
109 sync_pb::BookmarkSpecifics new_value = GetBookmarkSpecifics(); 109 sync_pb::BookmarkSpecifics new_value = GetBookmarkSpecifics();
110 new_value.set_url(url.spec()); 110 new_value.set_url(url.possibly_invalid_spec());
111 SetBookmarkSpecifics(new_value); 111 SetBookmarkSpecifics(new_value);
112 } 112 }
113 113
114 void WriteNode::SetAppSpecifics( 114 void WriteNode::SetAppSpecifics(
115 const sync_pb::AppSpecifics& new_value) { 115 const sync_pb::AppSpecifics& new_value) {
116 sync_pb::EntitySpecifics entity_specifics; 116 sync_pb::EntitySpecifics entity_specifics;
117 entity_specifics.mutable_app()->CopyFrom(new_value); 117 entity_specifics.mutable_app()->CopyFrom(new_value);
118 SetEntitySpecifics(entity_specifics); 118 SetEntitySpecifics(entity_specifics);
119 } 119 }
120 120
(...skipping 378 matching lines...) Expand 10 before | Expand all | Expand 10 after
499 sync_pb::BookmarkSpecifics new_value = GetBookmarkSpecifics(); 499 sync_pb::BookmarkSpecifics new_value = GetBookmarkSpecifics();
500 new_value.set_favicon(bytes.empty() ? NULL : &bytes[0], bytes.size()); 500 new_value.set_favicon(bytes.empty() ? NULL : &bytes[0], bytes.size());
501 SetBookmarkSpecifics(new_value); 501 SetBookmarkSpecifics(new_value);
502 } 502 }
503 503
504 void WriteNode::MarkForSyncing() { 504 void WriteNode::MarkForSyncing() {
505 syncable::MarkForSyncing(entry_); 505 syncable::MarkForSyncing(entry_);
506 } 506 }
507 507
508 } // namespace sync_api 508 } // namespace sync_api
OLDNEW
« no previous file with comments | « net/url_request/view_cache_helper.cc ('k') | webkit/database/database_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698