Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 10578013: Merged r11847, r11854 into 3.11 branch. (Closed)

Created:
8 years, 6 months ago by Toon Verwaest
Modified:
8 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Merged r11847, r11854 into 3.11 branch. Fix MSVC warnings about missing operator delete. Make sure we don't leak map transitions from AccessorPairs to the Javascript world. BUG=133211 R=jkummerow@chromium.org TEST= Committed: https://code.google.com/p/v8/source/detail?r=11857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -25 lines) Patch
M src/list.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M src/splay-tree.h View 2 chunks +11 lines, -2 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-133211.js View 1 chunk +8 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Toon Verwaest
8 years, 6 months ago (2012-06-19 11:53:12 UTC) #1
Jakob Kummerow
8 years, 6 months ago (2012-06-19 11:54:52 UTC) #2
LGTM (rubberstamped).

Powered by Google App Engine
This is Rietveld 408576698