Issue 10578012: Neuter alternate methods of entering fullscreen mode when in metro snap (via extension and via JS f…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10578012: Neuter alternate methods of entering fullscreen mode when in metro snap (via extension and via JS f… (Closed)

Created:
8 years, 6 months ago by robertshield

Modified:
8 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, ben+watch_chromium.org, chrome-win8-eng_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Neuter alternate methods of entering fullscreen mode when in metro snap (via extension and via JS fs api). Correct appearance of fullscreen bubble when moving from fullscreen non-snap to snap to non-snap. BUG=130623 TEST=Open metro chrome. Enter fullscreen mode. Enter metro snap mode. Exit metro snap mode. Observe fullscreen is exited, no bubble appears. Also, visit a page that uses JS or extension APIS to enter fullscreen mode while in metro snap. Observe that those API calls do not enter fullscreen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142956

Patch Set 1 #

Patch Set 2 : Cleanup. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -44 lines)			Patch
M	chrome/browser/ui/fullscreen_controller.cc	View		3 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	ui/views/widget/native_widget_win.h	View	1	1 chunk	+3 lines, -7 lines	0 comments	Download
M	ui/views/widget/native_widget_win.cc	View	1	3 chunks	+18 lines, -35 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/10578012/5001

8 years, 6 months ago (2012-06-19 14:06:08 UTC) #3

Change committed as 142956

Expand Messages | Collapse Messages