Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
105773005:
Add ability to specify email subject for gatekeeper_ng. (Closed)
|
Created:
7 years ago by ghost stip (do not use) Modified:
7 years ago Reviewers:
iannucci CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org Visibility:
Public. |
DescriptionAdd ability to specify email subject for gatekeeper_ng.
BUG=254525
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=241322
Patch Set 1 #
Total comments: 2
Messages
Total messages: 10 (0 generated)
ptal
lgtm https://codereview.chromium.org/105773005/diff/1/scripts/slave/gatekeeper_ng.py File scripts/slave/gatekeeper_ng.py (right): https://codereview.chromium.org/105773005/diff/1/scripts/slave/gatekeeper_ng.... scripts/slave/gatekeeper_ng.py:396: return gatekeeper_config This whole function is pretty funky. It may be worth thinking about how to refactor this so that the bare python types (dict, str, etc.) get parsed into a stronger more-typed hierarchy of composed classes.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stip@chromium.org/105773005/1
Presubmit check for 105773005-1 failed and returned exit status 1.
Running presubmit commit checks ...
** Presubmit ERRORS **
tests/masters_test.py (27.07s) failed
=== Error running master.chromium.fyi ===
2013-12-17 09:35:39-0800 [-] Starting factory
<buildbot.status.web.baseweb.RotateLogSite instance at 0x4dc0950>
2013-12-17 09:35:39-0800 [-] Setting up http.log rotating 10 files of 1000000
bytes each
2013-12-17 09:35:39-0800 [-] WebStatus using
(/b/commit-queue/workdir/tools/build/masters/master.chromium/public_html)
2013-12-17 09:35:39-0800 [-] adding IStatusReceiver
<master.chromium_notifier.ChromiumNotifier instance at 0x4accd88>
2013-12-17 09:35:39-0800 [-] adding IStatusReceiver
<master.failures_notifier.FailuresNotifier instance at 0x4accef0>
2013-12-17 09:35:39-0800 [-] adding IStatusReceiver
<buildbot.status.mail.MailNotifier instance at 0x4ad90e0>
2013-12-17 09:35:39-0800 [-] removing 0 old schedulers, updating 0, and adding
15
2013-12-17 09:35:39-0800 [-] hourly: missed scheduled build time, so building
immediately
2013-12-17 09:35:40-0800 [-] added buildset 1 to database
2013-12-17 09:35:44-0800 [-] Unhandled Error
Traceback (most recent call last):
Failure: twisted.internet.defer.FirstError: FirstError[#11, [Failure instance:
Traceback: <class 'sqlalchemy.exc.OperationalError'>: (OperationalError)
database is locked u'INSERT INTO schedulers (name, state, class_name) VALUES (?,
?, ?)' ('chromium_codesearch', '{}',
'buildbot.schedulers.triggerable.Triggerable')
/usr/lib/python2.7/threading.py:524:__bootstrap
/usr/lib/python2.7/threading.py:551:__bootstrap_inner
/usr/lib/python2.7/threading.py:504:run
--- <exception caught here> ---
/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/threadpool.py:207:_worker
/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/context.py:59:callWithContext
/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/context.py:37:callWithContext
/b/commit-queue/workdir/tools/build/third_party/buildbot_8_4p1/buildbot/db/pool.py:112:thd
/b/commit-queue/workdir/tools/build/third_party/buildbot_8_4p1/buildbot/db/schedulers.py:165:thd
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1358:execute
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1491:_execute_clauseelement
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1599:_execute_context
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1592:_execute_context
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/default.py:325:do_execute
]]
=== Error running master.chromium.webrtc.fyi ===
2013-12-17 09:35:32-0800 [-] WebStatus using
(/b/commit-queue/workdir/tools/build/masters/master.chromium/public_html)
2013-12-17 09:35:32-0800 [-] adding IStatusReceiver <WebStatus on port tcp:8256
at 0x413eea8>
2013-12-17 09:35:32-0800 [-] buildbot.status.web.baseweb.RotateLogSite starting
on 8256
2013-12-17 09:35:32-0800 [-] Starting factory
<buildbot.status.web.baseweb.RotateLogSite instance at 0x421ca28>
2013-12-17 09:35:32-0800 [-] Setting up http.log rotating 10 files of 1000000
bytes each
2013-12-17 09:35:32-0800 [-] WebStatus using
(/b/commit-queue/workdir/tools/build/masters/master.chromium/public_html)
2013-12-17 09:35:32-0800 [-] removing 0 old schedulers, updating 0, and adding
11
2013-12-17 09:35:34-0800 [-] cros_periodic_scheduler: missed scheduled build
time, so building immediately
2013-12-17 09:35:34-0800 [-] added buildset 1 to database
2013-12-17 09:35:37-0800 [-] Unhandled Error
Traceback (most recent call last):
Failure: twisted.internet.defer.FirstError: FirstError[#3, [Failure instance:
Traceback: <class 'sqlalchemy.exc.OperationalError'>: (OperationalError)
database is locked u'INSERT INTO schedulers (name, state, class_name) VALUES (?,
?, ?)' ('android_webrtc_scheduler', '{}', 'buildbot.schedulers.basic.Scheduler')
/usr/lib/python2.7/threading.py:524:__bootstrap
/usr/lib/python2.7/threading.py:551:__bootstrap_inner
/usr/lib/python2.7/threading.py:504:run
--- <exception caught here> ---
/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/threadpool.py:207:_worker
/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/context.py:59:callWithContext
/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/context.py:37:callWithContext
/b/commit-queue/workdir/tools/build/third_party/buildbot_8_4p1/buildbot/db/pool.py:112:thd
/b/commit-queue/workdir/tools/build/third_party/buildbot_8_4p1/buildbot/db/schedulers.py:165:thd
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1358:execute
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1491:_execute_clauseelement
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1599:_execute_context
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1592:_execute_context
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/default.py:325:do_execute
]]
=== Error running master.client.dart ===
2013-12-17 09:35:41-0800 [-] adding IStatusReceiver
<buildbot.status.status_push.HttpStatusPush instance at 0x3fe83b0>
2013-12-17 09:35:42-0800 [-] removing 0 old schedulers, updating 0, and adding
18
2013-12-17 09:35:43-0800 [-] Starting factory <HTTPClientFactory:
http://108.170.219.8:8080/submit-buildbot-info/>
2013-12-17 09:35:43-0800 [HTTPPageGetter,client] Sent 200 events to
http://108.170.219.8:8080/submit-buildbot-info/
2013-12-17 09:35:43-0800 [HTTPPageGetter,client] Stopping factory
<HTTPClientFactory: http://108.170.219.8:8080/submit-buildbot-info/>
2013-12-17 09:35:44-0800 [-] Starting factory <HTTPClientFactory:
http://108.170.219.8:8080/submit-buildbot-info/>
2013-12-17 09:35:45-0800 [HTTPPageGetter,client] Sent 200 events to
http://108.170.219.8:8080/submit-buildbot-info/
2013-12-17 09:35:45-0800 [HTTPPageGetter,client] Stopping factory
<HTTPClientFactory: http://108.170.219.8:8080/submit-buildbot-info/>
2013-12-17 09:35:46-0800 [-] Starting factory <HTTPClientFactory:
http://108.170.219.8:8080/submit-buildbot-info/>
2013-12-17 09:35:47-0800 [-] Unhandled Error
Traceback (most recent call last):
Failure: twisted.internet.defer.FirstError: FirstError[#3, [Failure instance:
Traceback: <class 'sqlalchemy.exc.OperationalError'>: (OperationalError)
database is locked u'INSERT INTO schedulers (name, state, class_name) VALUES (?,
?, ?)' ('scheduler-arm-dev', '{}',
'buildbot.schedulers.triggerable.Triggerable')
/usr/lib/python2.7/threading.py:524:__bootstrap
/usr/lib/python2.7/threading.py:551:__bootstrap_inner
/usr/lib/python2.7/threading.py:504:run
--- <exception caught here> ---
/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/threadpool.py:207:_worker
/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/context.py:59:callWithContext
/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/context.py:37:callWithContext
/b/commit-queue/workdir/tools/build/third_party/buildbot_8_4p1/buildbot/db/pool.py:112:thd
/b/commit-queue/workdir/tools/build/third_party/buildbot_8_4p1/buildbot/db/schedulers.py:165:thd
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1358:execute
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1491:_execute_clauseelement
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1599:_execute_context
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1592:_execute_context
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/default.py:325:do_execute
]]
=== Error running master.client.polymer ===
2013-12-17 09:35:33-0800 [-] Setting up http.log rotating 10 files of 1000000
bytes each
2013-12-17 09:35:33-0800 [-] WebStatus using
(/b/commit-queue/workdir/tools/build/masters/master.client.polymer/public_html)
2013-12-17 09:35:33-0800 [-] addi4 masters failed:
master.chromium.fyi
master.chromium.webrtc.fyi
master.client.dart
master.client.polymer
48 masters succeeded, 4 failed, 1 skipped in 26.9s.
ng IStatusReceiver <WebStatus on port tcp:8244 at 0x3934950>
2013-12-17 09:35:33-0800 [-] buildbot.status.web.baseweb.RotateLogSite starting
on 8244
2013-12-17 09:35:33-0800 [-] Starting factory
<buildbot.status.web.baseweb.RotateLogSite instance at 0x2b742403c830>
2013-12-17 09:35:33-0800 [-] Setting up http.log rotating 10 files of 1000000
bytes each
2013-12-17 09:35:33-0800 [-] WebStatus using
(/b/commit-queue/workdir/tools/build/masters/master.client.polymer/public_html)
2013-12-17 09:35:33-0800 [-] adding IStatusReceiver
<buildbot.status.mail.MailNotifier instance at 0x3934b48>
2013-12-17 09:35:33-0800 [-] removing 0 old schedulers, updating 0, and adding
37
2013-12-17 09:35:38-0800 [-] Unhandled Error
Traceback (most recent call last):
Failure: twisted.internet.defer.FirstError: FirstError[#2, [Failure instance:
Traceback: <class 'sqlalchemy.exc.OperationalError'>: (OperationalError)
database is locked u'INSERT INTO schedulers (name, state, class_name) VALUES (?,
?, ?)' ('platform-dev-polymer-expressions', '{}',
'buildbot.schedulers.basic.Scheduler')
/usr/lib/python2.7/threading.py:524:__bootstrap
/usr/lib/python2.7/threading.py:551:__bootstrap_inner
/usr/lib/python2.7/threading.py:504:run
--- <exception caught here> ---
/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/threadpool.py:207:_worker
/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/context.py:59:callWithContex…
(message too large)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stip@chromium.org/105773005/1
Presubmit check for 105773005-1 failed and returned exit status 1.
Running presubmit commit checks ...
** Presubmit ERRORS **
tests/masters_test.py (21.73s) failed
=== Error running master.chromium.webrtc.fyi ===
2013-12-17 09:44:14-0800 [-] Starting factory
<buildbot.status.web.baseweb.RotateLogSite instance at 0x4404518>
2013-12-17 09:44:14-0800 [-] Setting up http.log rotating 10 files of 1000000
bytes each
2013-12-17 09:44:14-0800 [-] WebStatus using
(/b/commit-queue/workdir/tools/build/masters/master.chromium/public_html)
2013-12-17 09:44:14-0800 [-] removing 0 old schedulers, updating 0, and adding
11
2013-12-17 09:44:16-0800 [-] win_periodic_scheduler: missed scheduled build
time, so building immediately
2013-12-17 09:44:16-0800 [-] mac_periodic_scheduler: missed scheduled build
time, so building immediately
2013-12-17 09:44:17-0800 [-] added buildset 1 to database
2013-12-17 09:44:17-0800 [-] android_periodic_scheduler: missed scheduled build
time, so building immediately
2013-12-17 09:44:18-0800 [-] cros_periodic_scheduler: missed scheduled build
time, so building immediately
2013-12-17 09:44:19-0800 [-] Unhandled Error
Traceback (most recent call last):
Failure: twisted.internet.defer.FirstError: FirstError[#3, [Failure instance:
Traceback: <class 'sqlalchemy.exc.OperationalError'>: (OperationalError)
database is locked u'INSERT INTO schedulers (name, state, class_name) VALUES (?,
?, ?)' ('android_webrtc_scheduler', '{}', 'buildbot.schedulers.basic.Scheduler')
/usr/lib/python2.7/threading.py:524:__bootstrap
/usr/lib/python2.7/threading.py:551:__bootstrap_inner
/usr/lib/python2.7/threading.py:504:run
--- <exception caught here> ---
/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/threadpool.py:207:_worker
/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/context.py:59:callWithContext
/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/context.py:37:callWithContext
/b/commit-queue/workdir/tools/build/third_party/buildbot_8_4p1/buildbot/db/pool.py:112:thd
/b/commit-queue/workdir/tools/build/third_party/buildbot_8_4p1/buildbot/db/schedulers.py:165:thd
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1358:execute
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1491:_execute_clauseelement
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1599:_execute_context
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1592:_execute_context
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/default.py:325:do_execute
]]
=== Error running master.client.polymer ===
2013-12-17 09:44:11-0800 [-] Setting up http.log rotating 10 files of 1000000
bytes each
2013-12-17 09:44:11-0800 [-] WebStatus using
(/b/commit-queue/workdir/tools/build/masters/master.client.polymer/public_html)
2013-12-17 09:44:11-0800 [-] adding IStatusReceiver <WebStatus on port tcp:8244
at 0x44c86c8>
2013-12-17 09:44:11-0800 [-] buildbot.status.web.baseweb.RotateLogSite starting
on 8244
2013-12-17 09:44:11-0800 [-] Starting factory
<buildbot.status.web.baseweb.RotateLogSite instance at 0x464ed88>
2013-12-17 09:44:11-0800 [-] Setting up http.log rotating 10 files of 1000000
bytes each
2013-12-17 09:44:11-0800 [-] WebStatus using
(/b/commit-queue/workdir/tools/build/masters/master.client.polymer/public_html)
2013-12-17 09:44:11-0800 [-] adding IStatusReceiver
<buildbot.status.mail.MailNotifier instance at 0x44c88c0>
2013-12-17 09:44:11-0800 [-] removing 0 old schedulers, updating 0, and adding
37
2013-12-17 09:44:16-0800 [-] Unhandled Error
Traceback (most recent call last):
Failure: twisted.internet.defer.FirstError: FirstError[#0, [Failure instance:
Traceback: <class 'sqlalchemy.exc.OperationalError'>: (OperationalError)
database is locked u'INSERT INTO schedulers (name, state, class_name) VALUES (?,
?, ?)' ('TemplateBinding', '{}', 'buildbot.schedulers.basic.Scheduler')
/usr/lib/python2.7/threading.py:524:__bootstrap
/usr/lib/python2.7/threading.py:551:__bootstrap_inner
/usr/lib/python2.7/threading.py:504:run
--- <exception c2 masters failed:
master.chromium.webrtc.fyi
master.client.polymer
50 masters succeeded, 2 failed, 1 skipped in 21.6s.
aught here> ---
/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/threadpool.py:207:_worker
/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/context.py:59:callWithContext
/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/context.py:37:callWithContext
/b/commit-queue/workdir/tools/build/third_party/buildbot_8_4p1/buildbot/db/pool.py:112:thd
/b/commit-queue/workdir/tools/build/third_party/buildbot_8_4p1/buildbot/db/schedulers.py:165:thd
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1358:execute
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1491:_execute_clauseelement
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1599:_execute_context
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1592:_execute_context
/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/default.py:325:do_execute
]]
Presubmit checks took 56.8s to calculate.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stip@chromium.org/105773005/1
Message was sent while issue was closed.
Change committed as 241322
Message was sent while issue was closed.
https://chromiumcodereview.appspot.com/105773005/diff/1/scripts/slave/gatekee... File scripts/slave/gatekeeper_ng.py (right): https://chromiumcodereview.appspot.com/105773005/diff/1/scripts/slave/gatekee... scripts/slave/gatekeeper_ng.py:396: return gatekeeper_config On 2013/12/17 00:46:23, iannucci wrote: > This whole function is pretty funky. It may be worth thinking about how to > refactor this so that the bare python types (dict, str, etc.) get parsed into a > stronger more-typed hierarchy of composed classes. Good point, might make it a bit easier to traverse and verify. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
