Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10577037: Add GL_CHROMIUM_get_error_query (Closed)

Created:
8 years, 6 months ago by greggman
Modified:
8 years, 5 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Add GL_CHROMIUM_get_error_query Makes it possible to asynchronously query GL errors. TEST=unit tests BUG=133630 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145739

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 1

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -60 lines) Patch
M gpu/command_buffer/client/atomicops.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 3 4 5 5 chunks +26 lines, -17 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 1 chunk +54 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/query_tracker.h View 1 2 3 4 4 chunks +9 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/query_tracker.cc View 1 2 3 4 5 6 2 chunks +43 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 2 3 4 5 6 1 chunk +8 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/gl_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 5 6 3 chunks +3 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/query_manager.h View 4 chunks +8 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/query_manager.cc View 1 4 chunks +50 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/query_manager_unittest.cc View 1 6 chunks +44 lines, -13 lines 0 comments Download
A gpu/command_buffer/tests/gl_get_error_query_unittests.cc View 1 1 chunk +53 lines, -0 lines 0 comments Download
M gpu/command_buffer_client.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/gpu.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/gpu_common.gypi View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M third_party/khronos/GLES2/gl2ext.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/khronos/README.chromium View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
greggman
Hey John, PTAL
8 years, 5 months ago (2012-06-27 21:10:36 UTC) #1
greggman
On 2012/06/27 21:10:36, greggman wrote: > Hey John, PTAL ping
8 years, 5 months ago (2012-06-29 01:19:53 UTC) #2
greggman
Hey Al, PTAL
8 years, 5 months ago (2012-07-08 22:59:24 UTC) #3
apatrick_chromium
lgtm http://codereview.chromium.org/10577037/diff/9003/gpu/command_buffer/client/query_tracker.cc File gpu/command_buffer/client/query_tracker.cc (right): http://codereview.chromium.org/10577037/diff/9003/gpu/command_buffer/client/query_tracker.cc#newcode82 gpu/command_buffer/client/query_tracker.cc:82: // There's on error on the client, no ...
8 years, 5 months ago (2012-07-09 19:27:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10577037/18002
8 years, 5 months ago (2012-07-09 19:48:00 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-09 21:07:02 UTC) #6 
Change committed as 145739

Powered by Google App Engine
This is Rietveld 408576698