Extensions Docs Server: HandlebarDictGenerator

chrome/common/extensions/docs/server2/api_data_source_test.py

Index: chrome/common/extensions/docs/server2/api_data_source_test.py
diff --git a/chrome/common/extensions/docs/server2/api_data_source_test.py b/chrome/common/extensions/docs/server2/api_data_source_test.py
index 3724140f57704b0a9e4615372adf6745f24594c5..023a4d2475fb8a37c10a229c2a3e96695bb4e0c8 100755
--- a/chrome/common/extensions/docs/server2/api_data_source_test.py
+++ b/chrome/common/extensions/docs/server2/api_data_source_test.py
@@ -11,6 +11,10 @@ from fetcher_cache import FetcherCache
 from local_fetcher import LocalFetcher
 from api_data_source import APIDataSource
 
+class TestAPIDataSource(APIDataSource):
+  def _LoadAPI(self, api):
+    return json.loads(api)[0]
+
 class APIDataSourceTest(unittest.TestCase):
   def setUp(self):
     self._base_path = os.path.join('test_data', 'api_data_source')
@@ -23,7 +27,7 @@ class APIDataSourceTest(unittest.TestCase):
     self._base_path = os.path.join(self._base_path, 'simple')
     fetcher = LocalFetcher(self._base_path)
     cache_builder = FetcherCache.Builder(fetcher, 0)
-    data_source = APIDataSource(cache_builder, ['./'])
+    data_source = TestAPIDataSource(cache_builder, ['./'])
 
     # Take the dict out of the list.
     expected = json.loads(self._ReadLocalFile('test_file.json'))[0]

[not at google - send to devlin, 2012/06/19 20:33:10]

Could you modify "expected" here rather than overriding _LoadAPI for
TestAPIDataSource? It's kind of defeating the purpose of testing APIDataSource
if you're going to override part of its behaviour.

[cduvall, 2012/06/19 22:21:02]

Done.