Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 10577015: roll rlz 130:132 (Closed)

Created:
8 years, 6 months ago by Nico
Modified:
8 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, jochen+watch-content_chromium.org, Roger Tawa OOO till Jul 10th
Visibility:
Public.

Description

roll rlz 130:132 131: Update the DEPS file so that the RLZ project can build standalone. 132: URLFetcher has moved from content to net, update references. Also remove now unnecessary code. No functionality change. BUG=118220 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142985

Patch Set 1 #

Patch Set 2 : 132 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -63 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/net/url_fetcher.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/url_fetcher.h View 2 chunks +0 lines, -23 lines 0 comments Download
D content/public/common/url_fetcher_delegate.h View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
8 years, 6 months ago (2012-06-19 14:22:08 UTC) #1
akalin
LGTM!
8 years, 6 months ago (2012-06-19 15:36:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10577015/3001
8 years, 6 months ago (2012-06-19 16:25:48 UTC) #3
commit-bot: I haz the power
Presubmit check for 10577015-3001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-19 16:25:59 UTC) #4
Avi (use Gerrit)
lgtm how about my OK, commitbot?
8 years, 6 months ago (2012-06-19 16:30:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10577015/3001
8 years, 6 months ago (2012-06-19 16:30:41 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-19 17:50:09 UTC) #7
Change committed as 142985

Powered by Google App Engine
This is Rietveld 408576698