Issue 10576013: Fix crash bug in Hydrogen occurring with empty prototype chain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10576013: Fix crash bug in Hydrogen occurring with empty prototype chain. (Closed)

Created:
8 years, 6 months ago by rossberg

Modified:
8 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix crash bug in Hydrogen occurring with empty prototype chain. (Thanks for diagnosing this.) R=vegorov@chromium.org BUG=115100 TEST= Committed: https://code.google.com/p/v8/source/detail?r=11861

Patch Set 2 : Addressed Slava's comment. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -1 line)			Patch
	M	src/hydrogen.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	A	test/mjsunit/regress/regress-115100.js	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

lgtm https://chromiumcodereview.appspot.com/10576013/diff/1/test/mjsunit/regress/regress-115100.js File test/mjsunit/regress/regress-115100.js (right): https://chromiumcodereview.appspot.com/10576013/diff/1/test/mjsunit/regress/regress-115100.js#newcode1 test/mjsunit/regress/regress-115100.js:1: // Copyright 2008 the V8 project authors. All ...

8 years, 6 months ago (2012-06-19 13:38:37 UTC) #2

rossberg

8 years, 6 months ago (2012-06-19 13:41:03 UTC) #3

https://chromiumcodereview.appspot.com/10576013/diff/1/test/mjsunit/regress/r...
File test/mjsunit/regress/regress-115100.js (right):

https://chromiumcodereview.appspot.com/10576013/diff/1/test/mjsunit/regress/r...
test/mjsunit/regress/regress-115100.js:1: // Copyright 2008 the V8 project
authors. All rights reserved.
On 2012/06/19 13:38:38, Vyacheslav Egorov wrote:
> 2012

Done.

Expand Messages | Collapse Messages

Issue 10576013: Fix crash bug in Hydrogen occurring with empty prototype chain. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed Slava's comment. #

Messages