Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: base/version_unittest.cc

Issue 10576003: VariationsService now supports wildcard in min/max version (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: addressed brettw's comment Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/version.cc ('k') | chrome/browser/metrics/variations_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/scoped_ptr.h" 5 #include "base/memory/scoped_ptr.h"
6 #include "base/version.h" 6 #include "base/version.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 class VersionTest : public testing::Test { 9 class VersionTest : public testing::Test {
10 }; 10 };
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 }; 82 };
83 for (size_t i = 0; i < ARRAYSIZE_UNSAFE(cases); ++i) { 83 for (size_t i = 0; i < ARRAYSIZE_UNSAFE(cases); ++i) {
84 scoped_ptr<Version> lhs(Version::GetVersionFromString(cases[i].lhs)); 84 scoped_ptr<Version> lhs(Version::GetVersionFromString(cases[i].lhs));
85 scoped_ptr<Version> rhs(Version::GetVersionFromString(cases[i].rhs)); 85 scoped_ptr<Version> rhs(Version::GetVersionFromString(cases[i].rhs));
86 EXPECT_EQ(lhs->CompareTo(*rhs), cases[i].expected) << 86 EXPECT_EQ(lhs->CompareTo(*rhs), cases[i].expected) <<
87 cases[i].lhs << " ? " << cases[i].rhs; 87 cases[i].lhs << " ? " << cases[i].rhs;
88 88
89 EXPECT_EQ(lhs->IsOlderThan(cases[i].rhs), (cases[i].expected == -1)); 89 EXPECT_EQ(lhs->IsOlderThan(cases[i].rhs), (cases[i].expected == -1));
90 } 90 }
91 } 91 }
92
93 TEST_F(VersionTest, CompareToWildcardString) {
94 static const struct version_compare {
95 const char* lhs;
96 const char* rhs;
97 int expected;
98 } cases[] = {
99 {"1.0", "1.*", 0},
100 {"1.0", "0.*", 1},
101 {"1.0", "2.*", -1},
102 {"1.2.3", "1.2.3.*", 0},
103 {"10.0", "1.0.*", 1},
104 {"1.0", "3.0.*", -1},
105 {"1.4", "1.3.0.*", 1},
106 {"1.3.9", "1.3.*", 0},
107 {"1.4.1", "1.3.*", 1},
108 {"1.3", "1.4.5.*", -1},
109 {"1.5", "1.4.5.*", 1},
110 {"1.3.9", "1.3.*", 0},
111 {"1.2.0.0.0.0", "1.2.*", 0},
112 };
113 for (size_t i = 0; i < ARRAYSIZE_UNSAFE(cases); ++i) {
114 const Version version(cases[i].lhs);
115 const int result = version.CompareToWildcardString(cases[i].rhs);
116 EXPECT_EQ(result, cases[i].expected) << cases[i].lhs << "?" << cases[i].rhs;
117 }
118 }
119
120 TEST_F(VersionTest, IsValidWildcardString) {
121 static const struct version_compare {
122 const char* version;
123 bool expected;
124 } cases[] = {
125 {"1.0", true},
126 {"", false},
127 {"1.2.3.4.5.6", true},
128 {"1.2.3.*", true},
129 {"1.2.3.5*", false},
130 {"1.2.3.56*", false},
131 {"1.*.3", false},
132 {"20.*", true},
133 {"+2.*", false},
134 {"*", false},
135 {"*.2", false},
136 };
137 for (size_t i = 0; i < ARRAYSIZE_UNSAFE(cases); ++i) {
138 EXPECT_EQ(Version::IsValidWildcardString(cases[i].version),
139 cases[i].expected) << cases[i].version << "?" << cases[i].expected;
140 }
141 }
OLDNEW
« no previous file with comments | « base/version.cc ('k') | chrome/browser/metrics/variations_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698