AppCache - Don't ignore network namespace entries when '*' is in the list.

Don't ignore network namespace entries when '*' is in the list.

BUG=133816
TEST=appcache_unittest + i need to update a layout test
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143410

[michaeln, 2012-06-20 23:34:55]

hi tony ptal... i still have to update tests for this, but i think i've got the
code changed to address the bug

[tony, 2012-06-20 23:38:52]

On 2012/06/20 23:34:55, michaeln wrote:
> hi tony ptal... i still have to update tests for this, but i think i've got
the
> code changed to address the bug

Is there someone familiar with this code that can do the review?  I'm happy to
forward on their LGTM.  We could also add them to the webkit/appcache/OWNERS
file.

[michaeln, 2012-06-21 00:04:20]

Finding a good reviewer is challenging. This stuff hasn't seen very active
development in quite some time. jennb is the most familiar since she wrote a
whole bunch if this too (actually i thought she was listed as an owner too and
am surprised to see she's not), but she 's been working on very different stuff
since then. ericu knows a thing or two about it, but he's about to be gone for
the week and i would like somebody to take a look at the test changes too once i
make them (so i didn't choose him as a victim).

So i thought i'd ask you to review so that you could gain some familiarity.

> Is there someone familiar with this code that can do the review?  I'm happy to
> forward on their LGTM.  We could also add them to the webkit/appcache/OWNERS
> file.

[michaeln, 2012-06-21 02:36:07]

There's a layout test that should be updated for this which i'll do separately,
the online-fallback-layering test, should add a '*' to that tests manifest file.

I've added a unittest to this CL to check the specific functions that got
changed.

[tony, 2012-06-21 16:48:09]

LGTM

https://chromiumcodereview.appspot.com/10575044/diff/6001/webkit/appcache/app...
File webkit/appcache/appcache_unittest.cc (right):

https://chromiumcodereview.appspot.com/10575044/diff/6001/webkit/appcache/app...
webkit/appcache/appcache_unittest.cc:330: const GURL
kFallbackUrl("http://foo.com/fallback.html");
Nit: FWIW, I think example.com is reserved so you can use that without risk of
hitting a real website.

https://chromiumcodereview.appspot.com/10575044/diff/6001/webkit/appcache/app...
webkit/appcache/appcache_unittest.cc:368: EXPECT_EQ(4321,
cache_record.group_id);
Nit: Can we put 1234 and 4321 in const variables?