Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: Source/WebCore/rendering/RenderBlock.cpp

Issue 10575040: Merge 120737 - Crash in RenderInline::willBeDestroyed. (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fullscreen/empty-anonymous-block-continuation-crash-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 1219 matching lines...) Expand 10 before | Expand all | Expand 10 after
1230 } 1230 }
1231 1231
1232 if (!firstChild() && !documentBeingDestroyed()) { 1232 if (!firstChild() && !documentBeingDestroyed()) {
1233 // If this was our last child be sure to clear out our line boxes. 1233 // If this was our last child be sure to clear out our line boxes.
1234 if (childrenInline()) 1234 if (childrenInline())
1235 deleteLineBoxTree(); 1235 deleteLineBoxTree();
1236 1236
1237 // If we are an empty anonymous block in the continuation chain, 1237 // If we are an empty anonymous block in the continuation chain,
1238 // we need to remove ourself and fix the continuation chain. 1238 // we need to remove ourself and fix the continuation chain.
1239 if (!beingDestroyed() && isAnonymousBlockContinuation()) { 1239 if (!beingDestroyed() && isAnonymousBlockContinuation()) {
1240 for (RenderObject* curr = this; curr; curr = curr->previousInPreOrde r(parent())) { 1240 RenderObject* containingBlockIgnoringAnonymous = containingBlock();
1241 while (containingBlockIgnoringAnonymous && containingBlockIgnoringAn onymous->isAnonymousBlock())
1242 containingBlockIgnoringAnonymous = containingBlockIgnoringAnonym ous->containingBlock();
1243 for (RenderObject* curr = this; curr; curr = curr->previousInPreOrde r(containingBlockIgnoringAnonymous)) {
1241 if (curr->virtualContinuation() != this) 1244 if (curr->virtualContinuation() != this)
1242 continue; 1245 continue;
1243 1246
1244 // Found our previous continuation. We just need to point it to 1247 // Found our previous continuation. We just need to point it to
1245 // |this|'s next continuation. 1248 // |this|'s next continuation.
1246 RenderBoxModelObject* nextContinuation = continuation(); 1249 RenderBoxModelObject* nextContinuation = continuation();
1247 if (curr->isRenderInline()) 1250 if (curr->isRenderInline())
1248 toRenderInline(curr)->setContinuation(nextContinuation); 1251 toRenderInline(curr)->setContinuation(nextContinuation);
1249 else if (curr->isRenderBlock()) 1252 else if (curr->isRenderBlock())
1250 toRenderBlock(curr)->setContinuation(nextContinuation); 1253 toRenderBlock(curr)->setContinuation(nextContinuation);
(...skipping 5998 matching lines...) Expand 10 before | Expand all | Expand 10 after
7249 } 7252 }
7250 7253
7251 String ValueToString<RenderBlock::FloatingObject*>::string(const RenderBlock::Fl oatingObject* floatingObject) 7254 String ValueToString<RenderBlock::FloatingObject*>::string(const RenderBlock::Fl oatingObject* floatingObject)
7252 { 7255 {
7253 return String::format("%p (%dx%d %dx%d)", floatingObject, floatingObject->fr ameRect().pixelSnappedX(), floatingObject->frameRect().pixelSnappedY(), floating Object->frameRect().pixelSnappedMaxX(), floatingObject->frameRect().pixelSnapped MaxY()); 7256 return String::format("%p (%dx%d %dx%d)", floatingObject, floatingObject->fr ameRect().pixelSnappedX(), floatingObject->frameRect().pixelSnappedY(), floating Object->frameRect().pixelSnappedMaxX(), floatingObject->frameRect().pixelSnapped MaxY());
7254 } 7257 }
7255 7258
7256 #endif 7259 #endif
7257 7260
7258 } // namespace WebCore 7261 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fullscreen/empty-anonymous-block-continuation-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698