dart/lib/isolate/frog/ports.dart - Issue 10575033: Implement override checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/lib/isolate/frog/ports.dart

Issue 10575033: Implement override checks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix problem that caused an assertion failure (and revert of the first attempt) Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/lib/isolate/frog/ports.dart

diff --git a/dart/lib/isolate/frog/ports.dart b/dart/lib/isolate/frog/ports.dart

index f7cddf477488be256ddc587a8ce16c83276550d9..68081a6a3059455d2d7905179d2b05ed6a9eb6aa 100644

--- a/dart/lib/isolate/frog/ports.dart

+++ b/dart/lib/isolate/frog/ports.dart

@@ -9,7 +9,7 @@ class _BaseSendPort implements SendPort {

const _BaseSendPort(this._isolateId);

- static void checkReplyTo(SendPort replyTo) {

+ void _checkReplyTo(SendPort replyTo) {

if (replyTo !== null

&& replyTo is! _NativeJsSendPort

&& replyTo is! _WorkerSendPort

@@ -46,7 +46,7 @@ class _NativeJsSendPort extends _BaseSendPort implements SendPort {

void send(var message, [SendPort replyTo = null]) {

_waitForPendingPorts([message, replyTo], () {

- checkReplyTo(replyTo);

+ _checkReplyTo(replyTo);

// Check that the isolate still runs and the port is still open

final isolate = _globalState.isolates[_isolateId];

if (isolate == null) return;

@@ -96,7 +96,7 @@ class _WorkerSendPort extends _BaseSendPort implements SendPort {

void send(var message, [SendPort replyTo = null]) {

_waitForPendingPorts([message, replyTo], () {

- checkReplyTo(replyTo);

+ _checkReplyTo(replyTo);

final workerMessage = _serializeMessage({

'command': 'message',

'port': this,

« no previous file with comments | « dart/lib/compiler/implementation/warnings.dart ('k') | dart/tests/co19/co19-leg.status » ('j') | no next file with comments »