Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2945)

Unified Diff: dart/lib/compiler/implementation/dart2js.dart

Issue 10575033: Implement override checks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix problem that caused an assertion failure (and revert of the first attempt) Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/lib/compiler/implementation/dart2js.dart
diff --git a/dart/lib/compiler/implementation/dart2js.dart b/dart/lib/compiler/implementation/dart2js.dart
index a4ce8c0ad021f619be40926d78c1adb932a2968a..7c147ffeac761571f1d965bdcc4082ae247ba4fa 100644
--- a/dart/lib/compiler/implementation/dart2js.dart
+++ b/dart/lib/compiler/implementation/dart2js.dart
@@ -194,8 +194,7 @@ void compile(List<String> argv) {
isAborting = kind === api.Diagnostic.CRASH;
bool fatal = (kind.ordinal & FATAL) != 0;
bool isInfo = (kind.ordinal & INFO) != 0;
- if (isInfo) {
- assert(uri === null);
+ if (isInfo && uri === null && kind !== api.Diagnostic.INFO) {
info(message, kind);
return;
}
@@ -210,6 +209,8 @@ void compile(List<String> argv) {
color = colors.magenta;
} else if (kind === api.Diagnostic.CRASH) {
color = colors.red;
+ } else if (kind === api.Diagnostic.INFO) {
+ color = colors.green;
} else {
throw 'Unknown kind: $kind (${kind.ordinal})';
}
« no previous file with comments | « dart/lib/compiler/implementation/compiler.dart ('k') | dart/lib/compiler/implementation/elements/elements.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698