dart/lib/compiler/implementation/apiimpl.dart - Issue 10575033: Implement override checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/lib/compiler/implementation/apiimpl.dart

Issue 10575033: Implement override checks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix problem that caused an assertion failure (and revert of the first attempt) Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/lib/compiler/implementation/apiimpl.dart

diff --git a/dart/lib/compiler/implementation/apiimpl.dart b/dart/lib/compiler/implementation/apiimpl.dart

index 709f190b4bea4c7494f4a8bd55b2d671d9b214de..ff5c5dce481ce81451abb29874dd4fb4139a858b 100644

--- a/dart/lib/compiler/implementation/apiimpl.dart

+++ b/dart/lib/compiler/implementation/apiimpl.dart

@@ -96,6 +96,9 @@ class Compiler extends leg.Compiler {

void reportDiagnostic(leg.SourceSpan span, String message,

api.Diagnostic kind) {

+ if (kind === api.Diagnostic.ERROR || kind === api.Diagnostic.CRASH) {

+ compilationFailed = true;

+ }

if (span === null) {

handler(null, null, null, message, kind);

} else {

« no previous file with comments | « no previous file | dart/lib/compiler/implementation/compiler.dart » ('j') | no next file with comments »