Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Side by Side Diff: src/property.cc

Issue 10575032: In-place shrinking of descriptor arrays with non-live transitions. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressing comments Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 break; 82 break;
83 case INTERCEPTOR: 83 case INTERCEPTOR:
84 PrintF(out, " -type = lookup interceptor\n"); 84 PrintF(out, " -type = lookup interceptor\n");
85 break; 85 break;
86 case CONSTANT_TRANSITION: 86 case CONSTANT_TRANSITION:
87 PrintF(out, " -type = constant property transition\n"); 87 PrintF(out, " -type = constant property transition\n");
88 PrintF(out, " -map:\n"); 88 PrintF(out, " -map:\n");
89 GetTransitionMap()->Print(out); 89 GetTransitionMap()->Print(out);
90 PrintF(out, "\n"); 90 PrintF(out, "\n");
91 break; 91 break;
92 case NULL_DESCRIPTOR: 92 case NONEXISTENT:
93 PrintF(out, " =type = null descriptor\n"); 93 UNREACHABLE();
94 break; 94 break;
95 } 95 }
96 } 96 }
97 97
98 98
99 void Descriptor::Print(FILE* out) { 99 void Descriptor::Print(FILE* out) {
100 PrintF(out, "Descriptor "); 100 PrintF(out, "Descriptor ");
101 GetKey()->ShortPrint(out); 101 GetKey()->ShortPrint(out);
102 PrintF(out, " @ "); 102 PrintF(out, " @ ");
103 GetValue()->ShortPrint(out); 103 GetValue()->ShortPrint(out);
(...skipping 12 matching lines...) Expand all
116 case CALLBACKS: { 116 case CALLBACKS: {
117 if (!value_->IsAccessorPair()) return false; 117 if (!value_->IsAccessorPair()) return false;
118 AccessorPair* accessors = AccessorPair::cast(value_); 118 AccessorPair* accessors = AccessorPair::cast(value_);
119 return accessors->getter()->IsMap() || accessors->setter()->IsMap(); 119 return accessors->getter()->IsMap() || accessors->setter()->IsMap();
120 } 120 }
121 case NORMAL: 121 case NORMAL:
122 case FIELD: 122 case FIELD:
123 case CONSTANT_FUNCTION: 123 case CONSTANT_FUNCTION:
124 case HANDLER: 124 case HANDLER:
125 case INTERCEPTOR: 125 case INTERCEPTOR:
126 case NULL_DESCRIPTOR:
127 return false; 126 return false;
127 case NONEXISTENT:
128 UNREACHABLE();
129 break;
128 } 130 }
129 UNREACHABLE(); // Keep the compiler happy. 131 UNREACHABLE(); // Keep the compiler happy.
130 return false; 132 return false;
131 } 133 }
132 134
133 135
134 } } // namespace v8::internal 136 } } // namespace v8::internal
OLDNEW
« src/objects.cc ('K') | « src/property.h ('k') | src/property-details.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698