lib/compiler/implementation/ssa/nodes.dart - Issue 10575030: Add a typeannotation and a missing argument to remove warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/nodes.dart

Issue 10575030: Add a typeannotation and a missing argument to remove warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/ssa/nodes.dart

diff --git a/lib/compiler/implementation/ssa/nodes.dart b/lib/compiler/implementation/ssa/nodes.dart

index c5525630131108cd5bea3fcf5d88119f22eadc0d..1b14d315d39a57808086698d9f343eeb61543cdf 100644

--- a/lib/compiler/implementation/ssa/nodes.dart

+++ b/lib/compiler/implementation/ssa/nodes.dart

@@ -1576,7 +1576,8 @@ class HShiftLeft extends HBinaryBitOp {

bool get builtin() {

if (!left.isInteger() || !right.isConstantInteger()) return false;

HConstant rightConstant = right;

- int count = rightConstant.constant.value;

+ IntConstant intConstant = rightConstant.constant;

+ int count = intConstant.value;

return count >= 0 && count <= 31;

}

« no previous file with comments | « no previous file | lib/compiler/implementation/unparse_validator.dart » ('j') | no next file with comments »