Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: content/browser/aura/owned_mailbox.cc

Issue 105743004: Add gpu::MailboxHolder to hold state for a gpu::Mailbox (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cc2a95fe Android fixes. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/aura/owned_mailbox.cc
diff --git a/content/browser/aura/owned_mailbox.cc b/content/browser/aura/owned_mailbox.cc
index 1a99d335ac245f3760d29c29af9c7ae531eb632b..bee0a760c5d125c2202641e60ff9268960a5cf71 100644
--- a/content/browser/aura/owned_mailbox.cc
+++ b/content/browser/aura/owned_mailbox.cc
@@ -11,31 +11,29 @@
namespace content {
OwnedMailbox::OwnedMailbox(GLHelper* gl_helper)
- : texture_id_(0), sync_point_(0), gl_helper_(gl_helper) {
+ : texture_id_(0), gl_helper_(gl_helper) {
texture_id_ = gl_helper_->CreateTexture();
- mailbox_ = gl_helper_->ProduceMailboxFromTexture(texture_id_, &sync_point_);
+ mailbox_holder_ = gl_helper_->ProduceMailboxHolderFromTexture(texture_id_);
ImageTransportFactory::GetInstance()->AddObserver(this);
}
OwnedMailbox::~OwnedMailbox() {
ImageTransportFactory::GetInstance()->RemoveObserver(this);
if (gl_helper_) {
- gl_helper_->WaitSyncPoint(sync_point_);
+ gl_helper_->WaitSyncPoint(mailbox_holder_.sync_point());
gl_helper_->DeleteTexture(texture_id_);
}
}
-void OwnedMailbox::UpdateSyncPoint(uint32 sync_point) {
- if (sync_point)
- sync_point_ = sync_point;
+void OwnedMailbox::set_sync_point(uint32 sync_point) {
+ mailbox_holder_.set_sync_point(sync_point);
piman 2013/12/06 23:29:42 We explicitly don't want to update the sync point
}
void OwnedMailbox::OnLostResources() {
- gl_helper_->WaitSyncPoint(sync_point_);
+ gl_helper_->WaitSyncPoint(mailbox_holder_.sync_point());
gl_helper_->DeleteTexture(texture_id_);
texture_id_ = 0;
- mailbox_ = gpu::Mailbox();
- sync_point_ = 0;
+ mailbox_holder_ = gpu::MailboxHolder();
gl_helper_ = NULL;
}

Powered by Google App Engine
This is Rietveld 408576698