Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: lib/compiler/implementation/namer.dart

Issue 10574046: Remove static fields in the namer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/enqueue.dart ('k') | lib/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/namer.dart
diff --git a/lib/compiler/implementation/namer.dart b/lib/compiler/implementation/namer.dart
index a5b960e7b04ab8da17c48c2f3c2739e29f900c6a..900842ae478df177f3ba957b730d1ba4e1cb23cd 100644
--- a/lib/compiler/implementation/namer.dart
+++ b/lib/compiler/implementation/namer.dart
@@ -8,10 +8,6 @@
class Namer {
final Compiler compiler;
- static final CLOSURE_INVOCATION_NAME = const SourceString('\$call');
- static final STATIC_CLOSURE_NAME_NAME = '\$name';
- static final OPERATOR_EQUALS = const SourceString('operator\$eq');
-
static Set<String> _jsReserved = null;
Set<String> get jsReserved() {
if (_jsReserved === null) {
@@ -31,9 +27,13 @@ class Namer {
usedGlobals = new Map<String, int>(),
shortPrivateNameOwners = new Map<String, LibraryElement>();
- final String CURRENT_ISOLATE = "\$";
- final String ISOLATE = "Isolate";
- final String ISOLATE_PROPERTIES = "\$isolateProperties";
+ final String CURRENT_ISOLATE = @'$';
+ final String ISOLATE = 'Isolate';
+ final String ISOLATE_PROPERTIES = @"$isolateProperties";
+ /** Some closures must contain their name. The name is stored in
+ * [STATIC_CLOSURE_NAME_NAME]. */
+ final String STATIC_CLOSURE_NAME_NAME = @'$name';
+ final SourceString CLOSURE_INVOCATION_NAME = const SourceString(@'$call');
String closureInvocationName(Selector selector) {
« no previous file with comments | « lib/compiler/implementation/enqueue.dart ('k') | lib/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698