chrome/browser/content_settings/cookie_settings.cc - Issue 10574045: Make third-party cookie blocking take precedence over any rules that match all hosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/cookie_settings.cc

Issue 10574045: Make third-party cookie blocking take precedence over any rules that match all hosts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/content_settings/cookie_settings.cc

diff --git a/chrome/browser/content_settings/cookie_settings.cc b/chrome/browser/content_settings/cookie_settings.cc

index ff27e3407a18adf7110289d501e72efa9a3fe022..fb2eb4f6a59a60810c3a2163ed8ffa8c938a986b 100644

--- a/chrome/browser/content_settings/cookie_settings.cc

+++ b/chrome/browser/content_settings/cookie_settings.cc

@@ -200,8 +200,8 @@ ContentSetting CookieSettings::GetCookieSetting(

// If no explicit exception has been made and third-party cookies are blocked

// by default, apply that rule.

- if (info.primary_pattern == ContentSettingsPattern::Wildcard() &&

- info.secondary_pattern == ContentSettingsPattern::Wildcard() &&

+ if (info.primary_pattern.MatchesAllHosts() &&

+ info.secondary_pattern.MatchesAllHosts() &&

ShouldBlockThirdPartyCookies() &&

!first_party_url.SchemeIs(chrome::kExtensionScheme)) {

bool not_strict = CommandLine::ForCurrentProcess()->HasSwitch(

« no previous file with comments | « no previous file | chrome/browser/content_settings/cookie_settings_unittest.cc » ('j') | no next file with comments »