Issue 10574045: Make third-party cookie blocking take precedence over any rules that match all hosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10574045: Make third-party cookie blocking take precedence over any rules that match all hosts. (Closed)

Created:
8 years, 6 months ago by Bernhard Bauer

Modified:
8 years, 6 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, jochen (gone - plz use gerrit)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make third-party cookie blocking take precedence over any rules that match all hosts. Previously, it would only take precedence over rules that match all origins ("*"). BUG=133768 TEST=see bug for manual test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143953

Patch Set 1 #

Patch Set 2 : test #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+131 lines, -106 lines)			Patch
M	chrome/browser/content_settings/cookie_settings.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/content_settings/cookie_settings_unittest.cc	View	1	1 chunk	+122 lines, -104 lines	0 comments	Download
M	chrome/common/content_settings_pattern.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/content_settings_pattern.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

That was fast :). Is it possible to write a test for this? I think ...

8 years, 6 months ago (2012-06-21 14:40:19 UTC) #2

Bernhard Bauer

On 2012/06/21 14:40:19, rsesek wrote: > That was fast :). Is it possible to write ...

8 years, 6 months ago (2012-06-25 09:28:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10574045/7001

8 years, 6 months ago (2012-06-25 15:22:49 UTC) #5

Change committed as 143953

Expand Messages | Collapse Messages