Remove chromeos::LibraryLoader

Remove chromeos::LibraryLoader

CrosLibrary::libcros_loaded()/load_error_string() will be removed later when there is no user for them
--stub-cros command line option is removed since our code uses stub CrosLibrary whenever libcros loading fails

BUG=127051
TEST=git try -b linux_chromeos,cros_x86

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143357

[satorux1, 2012-06-20 16:18:31]

LGTM, but please wait for stevenjb's review.

[stevenjb, 2012-06-20 17:26:47]

lgtm with one change request

http://codereview.chromium.org/10574040/diff/5019/chrome/browser/chromeos/cro...
File chrome/browser/chromeos/cros/cert_library.cc (right):

http://codereview.chromium.org/10574040/diff/5019/chrome/browser/chromeos/cro...
chrome/browser/chromeos/cros/cert_library.cc:158: is_stub_mode_) {
This really shouldn't be tied to stub_mode, it should be tied directly to
!IsRunningOnChromeOS(). Let's just ignore the stub argument in the constructor
for now, and create a TODO + issue to disassociate CertLibrary from CrosLibrary
entirely; I never should have associated the two in the first place.

Created issue: crbug.com/133752

[commit-bot: I haz the power, 2012-06-21 06:01:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10574040/10001

[hashimoto, 2012-06-21 06:20:59]

http://codereview.chromium.org/10574040/diff/5019/chrome/browser/chromeos/cro...
File chrome/browser/chromeos/cros/cert_library.cc (right):

http://codereview.chromium.org/10574040/diff/5019/chrome/browser/chromeos/cro...
chrome/browser/chromeos/cros/cert_library.cc:158: is_stub_mode_) {
On 2012/06/20 17:26:47, stevenjb (chromium) wrote:
> This really shouldn't be tied to stub_mode, it should be tied directly to
> !IsRunningOnChromeOS(). Let's just ignore the stub argument in the constructor
> for now, and create a TODO + issue to disassociate CertLibrary from
CrosLibrary
> entirely; I never should have associated the two in the first place.
> 
> Created issue: crbug.com/133752

Done.

[commit-bot: I haz the power, 2012-06-21 07:08:30]

Change committed as 143357