Add dart:web to VM.

Add dart:web to VM.
Committed: https://code.google.com/p/dart/source/detail?r=8993

[Emily Fortuna, 2012-06-20 01:57:38]

Hi Ivan,
Lasse recently added dart:web as one of the builtin libraries
(https://chromiumcodereview.appspot.com/10563023/). This change also allows
dart:web to be recognized in the VM as well.

[siva, 2012-06-20 02:07:39]

DBC

https://chromiumcodereview.appspot.com/10574037/diff/3002/runtime/bin/gen_sna...
File runtime/bin/gen_snapshot.cc (right):

https://chromiumcodereview.appspot.com/10574037/diff/3002/runtime/bin/gen_sna...
runtime/bin/gen_snapshot.cc:193: } else {
As more and more of these libraries get added to the embedder the snapshot size
increases and adds to the isolate initialization time. We already have
complaints that the isolate startup is slow.

Why does this library need to be part of the snapshot, can't it just exist in
source form and be loaded when somebody does a "#import("dart:web");

[Lasse Reichstein Nielsen, 2012-06-20 08:26:15]

On 2012/06/20 02:07:39, asiva wrote:
> DBC
... 
> Why does this library need to be part of the snapshot, can't it just exist in
> source form and be loaded when somebody does a "#import("dart:web");

Drive-by opinion: It should be fine to have this as source only. It's not a
"core" library that you can't use the language without, or a library that you
are certain to use.
On the other hand, it's possible that the library could be included bu dart:html
or dart:io in the future, and I guess the html library is preloaded in the
browser VM snapshot (because it's expected to be used).

[Lasse Reichstein Nielsen, 2012-06-20 08:28:40]

And drive-by review. Thank deity I didn't try to figure this out myself!

http://codereview.chromium.org/10574037/diff/9003/runtime/bin/builtin.cc
File runtime/bin/builtin.cc (right):

http://codereview.chromium.org/10574037/diff/9003/runtime/bin/builtin.cc#newc...
runtime/bin/builtin.cc:21: { DartUtils::kWebLibURL,     json_source_,     false
}
json_source_ -> web_source_

http://codereview.chromium.org/10574037/diff/9003/runtime/bin/web_sources.gypi
File runtime/bin/web_sources.gypi (right):

http://codereview.chromium.org/10574037/diff/9003/runtime/bin/web_sources.gyp...
runtime/bin/web_sources.gypi:5: # This file contains all sources for the
dart:utf library.
dart:utf -> dart:web

[Emily Fortuna, 2012-06-20 16:30:00]

@asiva: You're right -- there's no reason to add it to snapshotting -- I was
just blindly following the example of the other libraries like UTF and json.
I'll remove the snapshotting!

> runtime/bin/builtin.cc:21: { DartUtils::kWebLibURL,     json_source_,    
false
> }
> json_source_ -> web_source_

Good catch. This was left over from my debugging, but I forgot to take it out.

[Emily Fortuna, 2012-06-20 17:49:32]

PTAL.

[siva, 2012-06-21 00:02:09]

lgtm

[siva, 2012-06-21 00:30:49]

https://chromiumcodereview.appspot.com/10574037/diff/13002/runtime/bin/builti...
File runtime/bin/builtin_nolib.cc (right):

https://chromiumcodereview.appspot.com/10574037/diff/13002/runtime/bin/builti...
runtime/bin/builtin_nolib.cc:21: { DartUtils::kWebLibURL,     NULL,           
false }
{ DartUtils::kWebLibURL,     web_source_,     false }

https://chromiumcodereview.appspot.com/10574037/diff/13002/runtime/bin/builti...
runtime/bin/builtin_nolib.cc:26: UNREACHABLE();
ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) ==
kInvalidLibrary);
ASSERT(id == kWebLibrary);
return Dart_NewString(builtin_libraries_[id].source_);

https://chromiumcodereview.appspot.com/10574037/diff/13002/runtime/bin/builti...
runtime/bin/builtin_nolib.cc:32: UNREACHABLE();
ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) ==
kInvalidLibrary);
ASSERT(id == kWebLibrary);

[Emily Fortuna, 2012-06-21 16:56:47]

Fixed up. It should be ready to go now. Thanks for the help, asiva!

https://chromiumcodereview.appspot.com/10574037/diff/13002/runtime/bin/builti...
File runtime/bin/builtin_nolib.cc (right):

https://chromiumcodereview.appspot.com/10574037/diff/13002/runtime/bin/builti...
runtime/bin/builtin_nolib.cc:21: { DartUtils::kWebLibURL,     NULL,           
false }
On 2012/06/21 00:30:49, asiva wrote:
> { DartUtils::kWebLibURL,     web_source_,     false }

Done.

https://chromiumcodereview.appspot.com/10574037/diff/13002/runtime/bin/builti...
runtime/bin/builtin_nolib.cc:26: UNREACHABLE();
On 2012/06/21 00:30:49, asiva wrote:
> ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) ==
> kInvalidLibrary);
> ASSERT(id == kWebLibrary);
> return Dart_NewString(builtin_libraries_[id].source_);

Done.