Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 10574034: Merge 120640 - [chromium] REGRESSION(r120346) ContentLayerPainter should clear rect to be painted (Closed)

Created:
8 years, 6 months ago by jamesr
Modified:
8 years, 6 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 120640 - [chromium] REGRESSION(r120346) ContentLayerPainter should clear rect to be painted https://bugs.webkit.org/show_bug.cgi?id=89376 Reviewed by Adrienne Walker. In r120346, a refactor moved a clearRect()/clip() call from ContentLayerPainter - which all ContentLayerChromiums use - out to OpaqueRectTrackingContentLayerDelegate - which all GraphicsLayerChromium backed layers use, but which callers using WebContentLayer directly do not use. This meant that the canvas wasn't cleared/clipped as WebContentLayerClient.h claimed it would be. This moves the clear and the clip into CanvasLayerTextureUpdater which all paths use, including layers that don't use the ContentLayerPainter. * platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerPainter::paint): * platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp: (WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents): TBR=jamesr@google.com BUG=132982 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+666 lines, -7 lines) Patch
M Source/WebCore/ChangeLog View 1 chunk +657 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/CanvasLayerTextureUpdater.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/ScrollbarLayerChromium.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
8 years, 6 months ago (2012-06-19 23:43:26 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698