Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 10574021: Fix wobbling of find bar. (Closed)

Created:
8 years, 6 months ago by Avi (use Gerrit)
Modified:
8 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Fix wobbling of find bar. BUG=133376 TEST=as in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
Note that this doesn't _completely_ fix the problem. If you type something that's under the ...
8 years, 6 months ago (2012-06-19 18:00:20 UTC) #1
Nico
LGTM I like it :-) Maybe you can file a rdar for the coreanimation thing.
8 years, 6 months ago (2012-06-19 18:25:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10574021/1
8 years, 6 months ago (2012-06-19 18:27:59 UTC) #3
Avi (use Gerrit)
Is this M20-worthy?
8 years, 6 months ago (2012-06-19 18:28:12 UTC) #4
Nico
On 2012/06/19 18:28:12, Avi wrote: > Is this M20-worthy? If dharani lets it in, yes. ...
8 years, 6 months ago (2012-06-19 18:29:47 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-19 19:40:27 UTC) #6
Change committed as 143021

Powered by Google App Engine
This is Rietveld 408576698