Issue 10573017: Rename SpellCheckCommon namespace to chrome.

Issue 10573017: Rename SpellCheckCommon namespace to chrome. (Closed)

Created:
8 years, 6 months ago by tfarina

Modified:
8 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename SpellCheckCommon namespace to chrome. BUG=133126, 133088 R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143200

Patch Set 2 : add spellcheck_common namespace #

Patch Set 3 : fix #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -18 lines)			Patch
M	chrome/browser/spellchecker/spellcheck_host.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/spellchecker/spellcheck_host_browsertest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/spellchecker/spellcheck_host_impl.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/spellchecker/spellcheck_platform_mac.mm	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/language_options_handler_common2.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/spellcheck_common.h	View	1	3 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/common/spellcheck_common.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck.cc	View	1 2	2 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck_unittest.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

http://codereview.chromium.org/10573017/diff/1/chrome/common/spellcheck_common.h File chrome/common/spellcheck_common.h (right): http://codereview.chromium.org/10573017/diff/1/chrome/common/spellcheck_common.h#newcode15 chrome/common/spellcheck_common.h:15: namespace chrome { namespace spellcheck_common { .. These function ...

8 years, 6 months ago (2012-06-19 22:53:59 UTC) #2

tfarina

http://codereview.chromium.org/10573017/diff/1/chrome/common/spellcheck_common.h File chrome/common/spellcheck_common.h (right): http://codereview.chromium.org/10573017/diff/1/chrome/common/spellcheck_common.h#newcode15 chrome/common/spellcheck_common.h:15: On 2012/06/19 22:53:59, Ben Goodger (Google) wrote: > namespace ...

8 years, 6 months ago (2012-06-19 23:08:25 UTC) #3

lgtm

Expand Messages | Collapse Messages