Issue 10573011: Fix return values for Harmony map and set operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10573011: Fix return values for Harmony map and set operations. (Closed)

Created:
8 years, 6 months ago by Michael Starzinger

Modified:
8 years, 6 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix return values for Harmony map and set operations. R=rossberg@chromium.org BUG=chromium:132741, chromium:132742 TEST=mjsunit/harmony/collections Committed: https://code.google.com/p/v8/source/detail?r=11869

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -8 lines)			Patch
M	src/collection.js	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	4 chunks	+4 lines, -4 lines	1 comment	Download
M	test/mjsunit/harmony/collections.js	View	2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rossberg

8 years, 6 months ago (2012-06-19 15:16:49 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10573011/diff/1/src/runtime.cc
File src/runtime.cc (left):

https://chromiumcodereview.appspot.com/10573011/diff/1/src/runtime.cc#oldcode757
src/runtime.cc:757: return isolate->heap()->undefined_symbol();
Oops! :)

Expand Messages | Collapse Messages