Add a presubmit warning for not using UNIT_TEST in source files.

Add a presubmit warning for not using UNIT_TEST in source files.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143389

[Jói, 2012-06-20 22:19:52]

LGTM, but suggest using standard CamelCaps naming, e.g.
CheckNoUnitTestMacroInSourceGkles. Up to you.
On Jun 20, 2012 9:41 PM, <jam@chromium.org> wrote:

> Reviewers: Jói,
>
> Description:
> Add a presubmit warning for not using UNIT_TEST in source files.
>
> Please review this at
http://codereview.chromium.**org/10572054/<http://codereview.chromium.org/105...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>  M     PRESUBMIT.py
>
>
> Index: PRESUBMIT.py
> ==============================**==============================**=======
> --- PRESUBMIT.py        (revision 143189)
> +++ PRESUBMIT.py        (working copy)
> @@ -221,6 +221,23 @@
>   return []
>
>
> +def _CheckNoUNIT_**TESTInSourceFiles(input_api, output_api):
> +  """Checks to make sure no source files use UNIT_TEST"""
> +  problems = []
> +  for f in input_api.AffectedFiles():
> +    if (not f.LocalPath().endswith(('.cc', '.mm'))):
> +      continue
> +
> +    for line_num, line in f.ChangedContents():
> +      if 'UNIT_TEST' in line:
> +        problems.append('    %s:%d' % (f.LocalPath(), line_num))
> +
> +  if not problems:
> +    return []
> +  return [output_api.**PresubmitPromptWarning('UNIT_**TEST is only for
> headers.\n' +
> +      '\n'.join(problems))]
> +
> +
>  def _CheckNoNewWStrings(input_api, output_api):
>   """Checks to make sure we don't introduce use of wstrings."""
>   problems = []
> @@ -302,6 +319,7 @@
>   results.extend(
>     _**CheckNoProductionCodeUsingTest**OnlyFunctions(input_api,
> output_api))
>   results.extend(_**CheckNoIOStreamInHeaders(**input_api, output_api))
> +  results.extend(_CheckNoUNIT_**TESTInSourceFiles(input_api, output_api))
>   results.extend(_**CheckNoNewWStrings(input_api, output_api))
>   results.extend(_**CheckNoDEPSGIT(input_api, output_api))
>   results.extend(_**CheckNoBannedFunctions(input_**api, output_api))
>
>
>

[jam, 2012-06-20 23:39:06]

On 2012/06/20 22:19:52, Jói wrote:
> LGTM, but suggest using standard CamelCaps naming, e.g.
> CheckNoUnitTestMacroInSourceGkles. Up to you.

ah, I was trying to follow existing stuff like _CheckNoDEPSGIT/IOStream which
seemed to match what they're looking for?

[Jói, 2012-06-21 11:06:11]

Either way is fine by me.
On Jun 20, 2012 11:39 PM, <jam@chromium.org> wrote:

> On 2012/06/20 22:19:52, Jói wrote:
>
>> LGTM, but suggest using standard CamelCaps naming, e.g.
>> CheckNoUnitTestMacroInSourceGk**les. Up to you.
>>
>
> ah, I was trying to follow existing stuff like _CheckNoDEPSGIT/IOStream
> which
> seemed to match what they're looking for?
>
>
http://codereview.chromium.**org/10572054/<http://codereview.chromium.org/105...
>