Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: dart/tools/testing/dart/test_runner.dart

Issue 10572047: Correctly detect unhandled exceptions on Windows. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tests/language/language_dart2js.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/test_runner.dart
diff --git a/dart/tools/testing/dart/test_runner.dart b/dart/tools/testing/dart/test_runner.dart
index e2853c79c0fe9428bf6935d216747df739520e59..35381a046c0f45b1405c48117607171197ae7deb 100644
--- a/dart/tools/testing/dart/test_runner.dart
+++ b/dart/tools/testing/dart/test_runner.dart
@@ -262,6 +262,9 @@ class TestOutputImpl implements TestOutput {
bool get unexpectedOutput() => !testCase.expectedOutcomes.contains(result);
bool get hasCrashed() {
+ // The Java dartc runner and dart2js exits with code 253 in case
+ // of unhandled exceptions.
+ if (exitCode == 253) return true;
if (Platform.operatingSystem == 'windows') {
// The VM uses std::abort to terminate on asserts.
// std::abort terminates with exit code 3 on Windows.
@@ -270,9 +273,7 @@ class TestOutputImpl implements TestOutput {
}
return (!timedOut && (exitCode < 0) && ((0x3FFFFF00 & exitCode) == 0));
}
- // The Java dartc runner exits with code 253 in case of unhandled
- // exceptions.
- return (!timedOut && ((exitCode < 0) || (exitCode == 253)));
+ return !timedOut && ((exitCode < 0));
}
bool get hasTimedOut() => timedOut;
« no previous file with comments | « dart/tests/language/language_dart2js.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698