Remove old Sleep and PostDelayedTask interfaces that use int ms instead of TimeDelta.

Remove old Sleep and PostDelayedTask interfaces that use int ms instead of TimeDelta.

The previous version of this patch was reverted due to crashing cros_x86 and cros_tegra2 builds.  See: http://codereview.chromium.org/9703053/

BUG=108171
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143401

[Ted Vessenes, 2012-06-20 03:36:14]

This patch went through a few weeks ago but got reverted due to crashing the
cros_x86 and cros_tegra2 builds.  I fixed those issues in other patches, so the
CL is basically the same (modulo some rebasing).  Here's the review list as best
I can make it out:

jar: base/*
jam: base/threading/*, content/public/browser/*
joaodasilva: chrome/browser/policy/*
abodenha: cloud_print/*
sky: content/browser/*
asanka: content/browser/download/*
sergeyu: remoting/*
michaeln: webkit/storage/*

I've run this against all the standard bots, plus the two cros bots that failed
earlier, and everything seems kosher (except for one apparent flake from
linux_chromeos).

Are there any other non-standard bots I should run this CL against?

[sky, 2012-06-20 04:04:32]

LGTM

[michaeln, 2012-06-20 04:13:02]

still lgtm

[Joao da Silva, 2012-06-20 08:10:16]

policy/ lgtm

https://chromiumcodereview.appspot.com/10572030/diff/1/base/threading/sequenc...
File base/threading/sequenced_worker_pool_task_runner.h (right):

https://chromiumcodereview.appspot.com/10572030/diff/1/base/threading/sequenc...
base/threading/sequenced_worker_pool_task_runner.h:63: #endif  //
BASE_THREADING_SEQUENCED_TASK_RUNNER_IMPL_H_
Nit: BASE_THREADING_SEQUENCED_WORKED_POOL_TASK_RUNNER_H_

[Randy Smith (Not in Mondays), 2012-06-20 13:05:03]

content/browser/download LGTM.

[jam, 2012-06-20 16:23:45]

content lgtm. i'm not an owner for the files that you touched in base/threading

[Albert Bodenhamer, 2012-06-20 16:30:07]

lgtm
cloudprint

[Wez, 2012-06-20 20:10:10]

LGTM remoting/

[jar (doing other things), 2012-06-20 20:22:33]

LGTM base (with tiny nit below)

https://chromiumcodereview.appspot.com/10572030/diff/1/base/message_loop.cc
File base/message_loop.cc (right):

https://chromiumcodereview.appspot.com/10572030/diff/1/base/message_loop.cc#n...
base/message_loop.cc:277: const tracked_objects::Location& from_here, const
base::Closure& task) {
nit: once we wrap the arg list, we go to 1 arg per line I think.

[Ted Vessenes, 2012-06-21 02:15:15]

The cros_x86 build is broken in the same way on the current master branch and
all other builds are passing, so I'm going to try pushing this through now.

[commit-bot: I haz the power, 2012-06-21 02:15:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10572030/13001

[commit-bot: I haz the power, 2012-06-21 03:39:00]

Try job failure for 10572030-13001 (retry) (retry) on linux_rel for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-06-21 15:08:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10572030/13001

[commit-bot: I haz the power, 2012-06-21 17:32:00]

Change committed as 143401